r81009 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81008‎ | r81009 | r81010 >
Date:00:20, 26 January 2011
Author:catrope
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_17/extensions/Collection/Collection.body.php (modified) (history)
  • /branches/REL1_17/extensions/Collection/Collection.hooks.php (modified) (history)
  • /branches/REL1_17/extensions/Collection/Collection.php (modified) (history)
  • /branches/REL1_17/extensions/Collection/Collection.suggest.php (modified) (history)
  • /branches/REL1_17/extensions/Collection/Collection.templates.php (modified) (history)
  • /branches/REL1_17/extensions/Collection/js/bookcreator.css (added) (history)
  • /branches/REL1_17/extensions/Collection/js/collection.js (modified) (history)
  • /branches/REL1_17/extensions/Collection/js/suggest.js (modified) (history)
  • /branches/REL1_17/phase3/includes/OutputPage.php (modified) (history)
  • /branches/REL1_17/phase3/includes/libs/JavaScriptDistiller.php (modified) (history)
  • /branches/REL1_17/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/default/jquery.ui.autocomplete.css (modified) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/default/jquery.ui.theme.css (modified) (history)
  • /branches/REL1_17/phase3/skins/common/commonPrint.css (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/Collection/Collection.php
@@ -154,10 +154,43 @@
155155 $wgHooks['SkinBuildSidebar'][] = 'CollectionHooks::buildSidebar';
156156 $wgHooks['SiteNoticeAfter'][] = 'CollectionHooks::siteNoticeAfter';
157157 $wgHooks['OutputPageCheckLastModified'][] = 'CollectionHooks::checkLastModified';
 158+$wgHooks['ResourceLoaderGetConfigVars'][] = 'CollectionHooks::resourceLoaderGetConfigVars';
158159
159160 $wgAvailableRights[] = 'collectionsaveasuserpage';
160161 $wgAvailableRights[] = 'collectionsaveascommunitypage';
161162
 163+$collResourceTemplate = array(
 164+ 'localBasePath' => "$dir/js",
 165+ 'remoteExtPath' => 'Collection/js'
 166+);
 167+
 168+$wgResourceModules += array(
 169+ 'ext.collection.jquery.json' => $collResourceTemplate + array(
 170+ 'scripts' => 'jquery.json.js'
 171+ ),
 172+ 'ext.collection.jquery.jstorage' => $collResourceTemplate + array(
 173+ 'scripts' => 'jstorage.js',
 174+ 'dependencies' => 'ext.collection.jquery.json'
 175+ ),
 176+ 'ext.collection.suggest' => $collResourceTemplate + array(
 177+ 'scripts' => 'suggest.js',
 178+ 'dependencies' => 'ext.collection.bookcreator'
 179+ ),
 180+ 'ext.collection' => $collResourceTemplate + array(
 181+ 'scripts' => 'collection.js',
 182+ 'dependencies' => array( 'ext.collection.bookcreator', 'jquery.ui.sortable' ),
 183+ ),
 184+ 'ext.collection.bookcreator' => $collResourceTemplate + array(
 185+ 'scripts' => 'bookcreator.js',
 186+ 'styles' => 'bookcreator.css',
 187+ 'dependencies' => 'ext.collection.jquery.jstorage'
 188+ ),
 189+ 'ext.collection.checkLoadFromLocalStorage' => $collResourceTemplate + array(
 190+ 'scripts' => 'check_load_from_localstorage.js',
 191+ 'dependencies' => 'ext.collection.jquery.jstorage'
 192+ )
 193+);
 194+
162195 # register global Ajax functions:
163196
164197 function wfAjaxGetCollection() {
Index: branches/REL1_17/extensions/Collection/Collection.suggest.php
@@ -66,6 +66,7 @@
6767
6868 $template = self::getCollectionSuggestTemplate( $mode, $param );
6969 $wgOut->setPageTitle( wfMsg( 'coll-suggest_title' ) );
 70+ $wgOut->addModules( 'ext.collection.suggest' );
7071 $wgOut->addTemplate( $template );
7172 }
7273
Index: branches/REL1_17/extensions/Collection/Collection.hooks.php
@@ -252,56 +252,11 @@
253253 }
254254 }
255255
256 - $html = Xml::element( 'script',
257 - array(
258 - 'type' => $wgJsMimeType,
259 - 'src' => "$jsPath/jquery.js?$wgCollectionStyleVersion",
260 - ),
261 - '', false
262 - );
263 -
264 - $html .= Xml::element( 'script',
265 - array(
266 - 'type' => $wgJsMimeType,
267 - 'src' => "$jsPath/jquery.json.js?$wgCollectionStyleVersion",
268 - ),
269 - '', false
270 - );
271 -
272 - $html .= Xml::element( 'script',
273 - array(
274 - 'type' => $wgJsMimeType,
275 - 'src' => "$jsPath/jstorage.js?$wgCollectionStyleVersion",
276 - ),
277 - '', false
278 - );
279 -
280 - $html .= Xml::element( 'script',
281 - array(
282 - 'type' => $wgJsMimeType,
283 - 'src' => "$jsPath/bookcreator.js?$wgCollectionStyleVersion",
284 - ),
285 - '', false
286 - );
287 - $html .= Xml::element( 'style',
288 - array( 'type' => 'text/css' ),
289 - <<<EOS
290 -#collectionpopup {
291 - position: absolute;
292 - padding: 4px;
293 - border: 1px solid #000;
294 - background-color: #fea;
295 - z-index: 9999;
296 - display: inline;
297 - font-size: 10pt;
298 -}
299 -EOS
300 - , false
301 - );
 256+ $wgOut->addModules( 'ext.collection.bookcreator' );
302257
303258 $addRemoveState = $mode;
304259
305 - $html .= Xml::element( 'div',
 260+ $html = Xml::element( 'div',
306261 array( 'style' => wfMsg( 'coll-book_creator_box_style' ) ),
307262 null
308263 );
@@ -563,5 +518,13 @@
564519 }
565520 return true;
566521 }
 522+
 523+ /**
 524+ * ResourceLoaderGetConfigVars hook
 525+ */
 526+ static function resourceLoaderGetConfigVars( &$vars ) {
 527+ $vars['wgCollectionVersion'] = $GLOBALS['wgCollectionVersion'];
 528+ return true;
 529+ }
567530 }
568531
Index: branches/REL1_17/extensions/Collection/js/bookcreator.css
@@ -0,0 +1,40 @@
 2+#collectionpopup {
 3+ position: absolute;
 4+ padding: 4px;
 5+ border: 1px solid #000;
 6+ background-color: #fea;
 7+ z-index: 9999;
 8+ display: inline;
 9+ font-size: 10pt;
 10+}
 11+
 12+.collection-button {
 13+ float: left;
 14+ padding: 0 10px;
 15+ border: 1px solid #777;
 16+ -webkit-border-radius: 8px;
 17+ -moz-border-radius: 8px;
 18+}
 19+
 20+.collection-button.ok {
 21+ /* @embed */
 22+ background: url(../images/green-button-back.png) center no-repeat;
 23+ margin-right: 10px;
 24+}
 25+
 26+.collection-button.cancel {
 27+ /* @embed */
 28+ background: url(../images/red-button-back.png) center no-repeat;
 29+}
 30+
 31+.collection-button a {
 32+ display: block;
 33+ color: #fff;
 34+ font-size: 1.1em;
 35+ font-weight: bold;
 36+ line-height: 1.8em;
 37+}
 38+
 39+.collection-button a:hover {
 40+ text-decoration: none;
 41+}
Property changes on: branches/REL1_17/extensions/Collection/js/bookcreator.css
___________________________________________________________________
Added: svn:eol-style
142 + native
Index: branches/REL1_17/extensions/Collection/js/collection.js
@@ -234,4 +234,4 @@
235235 }
236236 });
237237
238 -})(collection_jQuery);
 238+})(jQuery);
Index: branches/REL1_17/extensions/Collection/js/suggest.js
@@ -39,5 +39,5 @@
4040
4141 window.collectionSuggestCall = collectionSuggestCall;
4242
43 -})(collection_jQuery);
 43+})(jQuery);
4444
Index: branches/REL1_17/extensions/Collection/Collection.body.php
@@ -321,14 +321,7 @@
322322 $imagepath = "$wgScriptPath/extensions/Collection/images";
323323 $jspath = "$wgScriptPath/extensions/Collection/js";
324324
325 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$jspath/jquery.js?" .
326 - "$wgCollectionStyleVersion\"></script>" );
327 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$jspath/jquery.json.js?" .
328 - "$wgCollectionStyleVersion\"></script>" );
329 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$jspath/jstorage.js?" .
330 - "$wgCollectionStyleVersion\"></script>" );
331 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$jspath/check_load_from_localstorage.js?" .
332 - "$wgCollectionStyleVersion\"></script>" );
 325+ $wgOut->addModules( 'ext.collection.checkLoadFromLocalStorage' );
333326
334327 $coll = CollectionSession::getCollection();
335328 $dialogtxt = wfMsg( 'coll-load_local_book' );
@@ -338,40 +331,6 @@
339332 "var collection_dialogtxt = " . Xml::encodeJsVar( $dialogtxt ) . ";\n" .
340333 "</script>" );
341334
342 - $wgOut->mScripts .= <<<EOS
343 -<style type="text/css">
344 -.collection-button {
345 - float: left;
346 - padding: 0 10px;
347 - border: 1px solid #777;
348 - -webkit-border-radius: 8px;
349 - -moz-border-radius: 8px;
350 -}
351 -
352 -.collection-button.ok {
353 - background: url($imagepath/green-button-back.png) center no-repeat;
354 - margin-right: 10px;
355 -}
356 -
357 -.collection-button.cancel {
358 - background: url($imagepath/red-button-back.png) center no-repeat;
359 -}
360 -
361 -.collection-button a {
362 - display: block;
363 - color: #fff;
364 - font-size: 1.1em;
365 - font-weight: bold;
366 - line-height: 1.8em;
367 -}
368 -
369 -.collection-button a:hover {
370 - text-decoration: none;
371 -}
372 -</style>
373 -EOS
374 - ;
375 -
376335 $title = Title::newFromText( $referer );
377336 if ( is_null( $title ) || $title->equals( $wgTitle ) ) {
378337 $title = Title::newMainPage();
@@ -522,11 +481,7 @@
523482
524483 $this->setHeaders();
525484 $wgOut->setPageTitle( wfMsg( 'coll-manage_your_book' ) );
526 - $wgOut->addInlineScript( "var wgCollectionVersion = \"$wgCollectionVersion\";" );
527 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$jspath/jquery.js?$wgCollectionStyleVersion\"></script>" );
528 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$jspath/jquery.ui.js?$wgCollectionStyleVersion\"></script>" );
529 - $wgOut->addInlineScript( "var collection_jQuery = jQuery.noConflict();" );
530 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$jspath/collection.js?$wgCollectionStyleVersion\"></script>" );
 485+ $wgOut->addModules( 'ext.collection' );
531486
532487 $template = new CollectionPageTemplate();
533488 $template->set( 'collection', CollectionSession::getCollection() );
@@ -1101,10 +1056,7 @@
11021057 $wgOut->addInlineScript( 'var collection_id = "' . urlencode( $response['collection_id'] ) . '";' );
11031058 $wgOut->addInlineScript( 'var writer = "' . urlencode( $response['writer'] ) . '";' );
11041059 $wgOut->addInlineScript( 'var collection_rendering = true;' );
1105 - $wgOut->addInlineScript( "var wgCollectionVersion = \"$wgCollectionVersion\";" );
1106 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/js/jquery.js?$wgCollectionStyleVersion\"></script>" );
1107 - $wgOut->addInlineScript( "var collection_jQuery = jQuery.noConflict();" );
1108 - $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/js/collection.js?$wgCollectionStyleVersion\"></script>" );
 1060+ $wgOut->addModules( 'ext.collection' );
11091061 $wgOut->setPageTitle( wfMsg( 'coll-rendering_title' ) );
11101062
11111063 if ( isset( $response['status']['status'] ) && $response['status']['status'] ) {
Index: branches/REL1_17/extensions/Collection/Collection.templates.php
@@ -446,13 +446,6 @@
447447 class CollectionSuggestTemplate extends QuickTemplate {
448448 function execute () {
449449 ?>
450 -<script src="<?php echo htmlspecialchars( $GLOBALS['wgScriptPath'] . "/extensions/Collection/js/jquery.js?" . $GLOBALS['wgCollectionStyleVersion'] ) ?>" type="<?php echo $GLOBALS['wgJsMimeType']; ?>"></script>
451 -<script type="<?php echo $GLOBALS['wgJsMimeType']; ?>">
452 -/*<![CDATA[*/
453 -var collection_jQuery = jQuery.noConflict();
454 -/*]]>*/
455 -</script>
456 -<script src="<?php echo $GLOBALS['wgScriptPath'] . "/extensions/Collection/js/suggest.js?" . $GLOBALS['wgCollectionStyleVersion'] ?>" type="<?php echo $GLOBALS['wgJsMimeType']; ?>"></script>
457450 <div>
458451 <?php $this->msg( 'coll-suggest_intro_text' ) ?>
459452 <div id="collectionSuggestStatus" style="text-align: center; margin: 5px auto 10px auto; padding: 0 4px; border: 1px solid #ed9; background-color: #fea; visibility: hidden;">&#160;</div>
Index: branches/REL1_17/phase3/skins/common/commonPrint.css
@@ -18,12 +18,9 @@
1919 background-color: #f9f9f9;
2020 padding: 5px;
2121 }
22 -body.ltr .tocindent {
 22+.tocindent {
2323 margin-left: 2em;
2424 }
25 -body.rtl .tocindent {
26 - margin-right: 2em;
27 -}
2825 .tocline {
2926 margin-bottom: 0px;
3027 }
@@ -35,11 +32,6 @@
3633 position: relative;
3734 margin: 0.5em 0 0.8em 1.4em;
3835 }
39 -body.rtl div.floatright {
40 - float: left;
41 - clear: left;
42 - margin: 0.5em 1.4em 0.8em 0;
43 -}
4436 div.floatright p {
4537 font-style: italic;
4638 }
@@ -49,11 +41,6 @@
5042 position: relative;
5143 margin: 0.5em 1.4em 0.8em 0;
5244 }
53 -body.rtl div.floatleft {
54 - float: right;
55 - clear: right;
56 - margin: 0.5em 0 0.8em 1.4em;
57 -}
5845 div.floatleft p {
5946 font-style: italic;
6047 }
@@ -84,9 +71,6 @@
8572 padding: 3px !important;
8673 font-size: 94%;
8774 }
88 -body.rtl .thumbcaption {
89 - text-align: right;
90 -}
9175
9276 div.magnify {
9377 display: none;
@@ -101,16 +85,6 @@
10286 clear: left;
10387 margin: 0.5em 1.4em 0.8em 0;
10488 }
105 -body.rtl div.tright {
106 - float: left;
107 - clear: left;
108 - border-width: 0.5em 1.4em 0.8em 0;
109 -}
110 -body.rtl div.tleft {
111 - float: right;
112 - clear: right;
113 - border-width: 0.5em 0 0.8em 1.4em;
114 -}
11589 img.thumbborder {
11690 border: 1px solid #dddddd;
11791 }
Index: branches/REL1_17/phase3/includes/OutputPage.php
@@ -233,7 +233,7 @@
234234 * @return Array of module names
235235 */
236236 public function getModules() {
237 - return $this->mModules;
 237+ return array_values( array_unique( $this->mModules ) );
238238 }
239239
240240 /**
@@ -252,7 +252,7 @@
253253 * @return array of module names
254254 */
255255 public function getModuleScripts() {
256 - return $this->mModuleScripts;
 256+ return array_values( array_unique( $this->mModuleScripts ) );
257257 }
258258
259259 /**
@@ -272,7 +272,7 @@
273273 * @return Array of module names
274274 */
275275 public function getModuleStyles() {
276 - return $this->mModuleStyles;
 276+ return array_values( array_unique( $this->mModuleStyles ) );
277277 }
278278
279279 /**
@@ -292,7 +292,7 @@
293293 * @return Array of module names
294294 */
295295 public function getModuleMessages() {
296 - return $this->mModuleMessages;
 296+ return array_values( array_unique( $this->mModuleMessages ) );
297297 }
298298
299299 /**
@@ -2350,7 +2350,7 @@
23512351 */
23522352 protected function makeResourceLoaderLink( Skin $skin, $modules, $only, $useESI = false ) {
23532353 global $wgUser, $wgLang, $wgLoadScript, $wgResourceLoaderUseESI,
2354 - $wgResourceLoaderInlinePrivateModules;
 2354+ $wgResourceLoaderInlinePrivateModules, $wgRequest;
23552355 // Lazy-load ResourceLoader
23562356 // TODO: Should this be a static function of ResourceLoader instead?
23572357 // TODO: Divide off modules starting with "user", and add the user parameter to them
@@ -2360,6 +2360,13 @@
23612361 'skin' => $skin->getSkinName(),
23622362 'only' => $only,
23632363 );
 2364+ // Propagate printable and handheld parameters if present
 2365+ if ( $wgRequest->getBool( 'printable' ) ) {
 2366+ $query['printable'] = 1;
 2367+ }
 2368+ if ( $wgRequest->getBool( 'handheld' ) ) {
 2369+ $query['handheld'] = 1;
 2370+ }
23642371
23652372 if ( !count( $modules ) ) {
23662373 return '';
@@ -2745,7 +2752,7 @@
27462753 }
27472754
27482755 if( isset( $options['media'] ) ) {
2749 - $media = $this->transformCssMedia( $options['media'] );
 2756+ $media = self::transformCssMedia( $options['media'] );
27502757 if( is_null( $media ) ) {
27512758 return '';
27522759 }
@@ -2777,7 +2784,7 @@
27782785 * @param $media String: current value of the "media" attribute
27792786 * @return String: modified value of the "media" attribute
27802787 */
2781 - function transformCssMedia( $media ) {
 2788+ public static function transformCssMedia( $media ) {
27822789 global $wgRequest, $wgHandheldForIPhone;
27832790
27842791 // Switch in on-screen display for media testing
Property changes on: branches/REL1_17/phase3/includes/OutputPage.php
___________________________________________________________________
Modified: svn:mergeinfo
27852792 Merged /trunk/phase3/includes/OutputPage.php:r79839,80003,80005
Index: branches/REL1_17/phase3/includes/resourceloader/ResourceLoader.php
@@ -390,7 +390,11 @@
391391 // See also http://bugs.php.net/bug.php?id=51579
392392 // To work around this, we tear down all output buffering before
393393 // sending the 304.
394 - while ( ob_get_level() > 0 ) {
 394+ // On some setups, ob_get_level() doesn't seem to go down to zero
 395+ // no matter how often we call ob_get_clean(), so instead of doing
 396+ // the more intuitive while ( ob_get_level() > 0 ) ob_get_clean();
 397+ // we have to be safe here and avoid an infinite loop.
 398+ for ( $i = 0; $i < ob_get_level(); $i++ ) {
395399 ob_end_clean();
396400 }
397401
@@ -575,7 +579,18 @@
576580 public static function makeCombinedStyles( array $styles ) {
577581 $out = '';
578582 foreach ( $styles as $media => $style ) {
579 - $out .= "@media $media {\n" . str_replace( "\n", "\n\t", "\t" . $style ) . "\n}\n";
 583+ // Transform the media type based on request params and config
 584+ // The way that this relies on $wgRequest to propagate request params is slightly evil
 585+ $media = OutputPage::transformCssMedia( $media );
 586+
 587+ if ( $media === null ) {
 588+ // Skip
 589+ } else if ( $media === '' || $media == 'all' ) {
 590+ // Don't output invalid or frivolous @media statements
 591+ $out .= "$style\n";
 592+ } else {
 593+ $out .= "@media $media {\n" . str_replace( "\n", "\n\t", "\t" . $style ) . "\n}\n";
 594+ }
580595 }
581596 return $out;
582597 }
Property changes on: branches/REL1_17/phase3/includes/resourceloader/ResourceLoader.php
___________________________________________________________________
Modified: svn:mergeinfo
583598 Merged /trunk/phase3/includes/resourceloader/ResourceLoader.php:r79839,79862
Index: branches/REL1_17/phase3/includes/libs/JavaScriptDistiller.php
@@ -21,7 +21,7 @@
2222 public static function stripWhiteSpace( $script, $stripVerticalSpace = false ) {
2323 $script = self::stripHorizontalSpace( $script );
2424 // If requested, make some vertical whitespace collapsing as well
25 - if ( $collapseVertical ) {
 25+ if ( $stripVerticalSpace ) {
2626 $script = self::stripVerticalSpace( $script );
2727 }
2828 // Done
Index: branches/REL1_17/phase3/resources/jquery.ui/themes/default/jquery.ui.autocomplete.css
@@ -1,7 +1,7 @@
22 /* Autocomplete
33 ----------------------------------*/
44 .ui-autocomplete { position: absolute; cursor: default; }
5 -.ui-autocomplete-loading { background: white url('images/ui-anim_basic_16x16.gif') right center no-repeat; }
 5+.ui-autocomplete-loading { background: white /* @embed */ url('images/ui-anim_basic_16x16.gif') right center no-repeat; }
66
77 /* workarounds */
88 * html .ui-autocomplete { width:1px; } /* without this, the menu expands to 100% in IE6 */
Index: branches/REL1_17/phase3/resources/jquery.ui/themes/default/jquery.ui.theme.css
@@ -13,26 +13,26 @@
1414 .ui-widget { font-family: sans-serif; font-size: 1em; }
1515 .ui-widget .ui-widget { font-size: 1em; }
1616 .ui-widget input, .ui-widget select, .ui-widget textarea, .ui-widget button { font-family: sans-serif; font-size: 1em; }
17 -.ui-widget-content { border: 1px solid #aaaaaa; background: #ffffff url(images/ui-bg_flat_75_ffffff_40x100.png) 50% 50% repeat-x; color: #222222; }
 17+.ui-widget-content { border: 1px solid #aaaaaa; /* @embed */ background: #ffffff url(images/ui-bg_flat_75_ffffff_40x100.png) 50% 50% repeat-x; color: #222222; }
1818 .ui-widget-content a { color: #222222; }
19 -.ui-widget-header { border: 1px solid #aaaaaa; background: #cccccc url(images/ui-bg_flat_75_cccccc_40x100.png) 50% 50% repeat-x; color: #222222; font-weight: bold; }
 19+.ui-widget-header { border: 1px solid #aaaaaa; /* @embed */ background: #cccccc url(images/ui-bg_flat_75_cccccc_40x100.png) 50% 50% repeat-x; color: #222222; font-weight: bold; }
2020 .ui-widget-header a { color: #222222; }
2121
2222 /* Interaction states
2323 ----------------------------------*/
24 -.ui-state-default, .ui-widget-content .ui-state-default, .ui-widget-header .ui-state-default { border: 1px solid #d3d3d3; background: #e6e6e6 url(images/ui-bg_flat_75_e6e6e6_40x100.png) 50% 50% repeat-x; font-weight: normal; color: #555555; }
 24+.ui-state-default, .ui-widget-content .ui-state-default, .ui-widget-header .ui-state-default { border: 1px solid #d3d3d3; /* @embed */ background: #e6e6e6 url(images/ui-bg_flat_75_e6e6e6_40x100.png) 50% 50% repeat-x; font-weight: normal; color: #555555; }
2525 .ui-state-default a, .ui-state-default a:link, .ui-state-default a:visited { color: #555555; text-decoration: none; }
26 -.ui-state-hover, .ui-widget-content .ui-state-hover, .ui-widget-header .ui-state-hover, .ui-state-focus, .ui-widget-content .ui-state-focus, .ui-widget-header .ui-state-focus { border: 1px solid #999999; background: #dadada url(images/ui-bg_flat_75_dadada_40x100.png) 50% 50% repeat-x; font-weight: normal; color: #212121; }
 26+.ui-state-hover, .ui-widget-content .ui-state-hover, .ui-widget-header .ui-state-hover, .ui-state-focus, .ui-widget-content .ui-state-focus, .ui-widget-header .ui-state-focus { border: 1px solid #999999; /* @embed */ background: #dadada url(images/ui-bg_flat_75_dadada_40x100.png) 50% 50% repeat-x; font-weight: normal; color: #212121; }
2727 .ui-state-hover a, .ui-state-hover a:hover { color: #212121; text-decoration: none; }
28 -.ui-state-active, .ui-widget-content .ui-state-active, .ui-widget-header .ui-state-active { border: 1px solid #aaaaaa; background: #ffffff url(images/ui-bg_flat_65_ffffff_40x100.png) 50% 50% repeat-x; font-weight: normal; color: #212121; }
 28+.ui-state-active, .ui-widget-content .ui-state-active, .ui-widget-header .ui-state-active { border: 1px solid #aaaaaa; /* @embed */ background: #ffffff url(images/ui-bg_flat_65_ffffff_40x100.png) 50% 50% repeat-x; font-weight: normal; color: #212121; }
2929 .ui-state-active a, .ui-state-active a:link, .ui-state-active a:visited { color: #212121; text-decoration: none; }
3030 .ui-widget :active { outline: none; }
3131
3232 /* Interaction Cues
3333 ----------------------------------*/
34 -.ui-state-highlight, .ui-widget-content .ui-state-highlight, .ui-widget-header .ui-state-highlight {border: 1px solid #fcefa1; background: #fbf9ee url(images/ui-bg_flat_55_fbf9ee_40x100.png) 50% 50% repeat-x; color: #363636; }
 34+.ui-state-highlight, .ui-widget-content .ui-state-highlight, .ui-widget-header .ui-state-highlight {border: 1px solid #fcefa1; /* @embed */ background: #fbf9ee url(images/ui-bg_flat_55_fbf9ee_40x100.png) 50% 50% repeat-x; color: #363636; }
3535 .ui-state-highlight a, .ui-widget-content .ui-state-highlight a,.ui-widget-header .ui-state-highlight a { color: #363636; }
36 -.ui-state-error, .ui-widget-content .ui-state-error, .ui-widget-header .ui-state-error {border: 1px solid #cd0a0a; background: #fef1ec url(images/ui-bg_flat_95_fef1ec_40x100.png) 50% 50% repeat-x; color: #cd0a0a; }
 36+.ui-state-error, .ui-widget-content .ui-state-error, .ui-widget-header .ui-state-error {border: 1px solid #cd0a0a; /* @embed */ background: #fef1ec url(images/ui-bg_flat_95_fef1ec_40x100.png) 50% 50% repeat-x; color: #cd0a0a; }
3737 .ui-state-error a, .ui-widget-content .ui-state-error a, .ui-widget-header .ui-state-error a { color: #cd0a0a; }
3838 .ui-state-error-text, .ui-widget-content .ui-state-error-text, .ui-widget-header .ui-state-error-text { color: #cd0a0a; }
3939 .ui-priority-primary, .ui-widget-content .ui-priority-primary, .ui-widget-header .ui-priority-primary { font-weight: bold; }
@@ -43,14 +43,12 @@
4444 ----------------------------------*/
4545
4646 /* states and images */
47 -.ui-icon { width: 16px; height: 16px; background-image: url(images/ui-icons_222222_256x240.png); }
48 -.ui-widget-content .ui-icon {background-image: url(images/ui-icons_222222_256x240.png); }
49 -.ui-widget-header .ui-icon {background-image: url(images/ui-icons_222222_256x240.png); }
50 -.ui-state-default .ui-icon { background-image: url(images/ui-icons_888888_256x240.png); }
51 -.ui-state-hover .ui-icon, .ui-state-focus .ui-icon {background-image: url(images/ui-icons_454545_256x240.png); }
52 -.ui-state-active .ui-icon {background-image: url(images/ui-icons_454545_256x240.png); }
53 -.ui-state-highlight .ui-icon {background-image: url(images/ui-icons_2e83ff_256x240.png); }
54 -.ui-state-error .ui-icon, .ui-state-error-text .ui-icon {background-image: url(images/ui-icons_cd0a0a_256x240.png); }
 47+.ui-icon { width: 16px; height: 16px; }
 48+.ui-icon, .ui-widget-content .ui-icon, .ui-widget-header .ui-icon { /* @embed */ background-image: url(images/ui-icons_222222_256x240.png); }
 49+.ui-state-default .ui-icon { /* @embed */ background-image: url(images/ui-icons_888888_256x240.png); }
 50+.ui-state-hover .ui-icon, .ui-state-focus .ui-icon, .ui-state-active .ui-icon { /* @embed */ background-image: url(images/ui-icons_454545_256x240.png); }
 51+.ui-state-highlight .ui-icon { /* @embed */ background-image: url(images/ui-icons_2e83ff_256x240.png); }
 52+.ui-state-error .ui-icon, .ui-state-error-text .ui-icon { /* @embed */ background-image: url(images/ui-icons_cd0a0a_256x240.png); }
5553
5654 /* positioning */
5755 .ui-icon-carat-1-n { background-position: 0 0; }
@@ -245,5 +243,6 @@
246244 .ui-corner-all { -moz-border-radius: 0; -webkit-border-radius: 0; border-radius: 0; }
247245
248246 /* Overlays */
249 -.ui-widget-overlay { background: #aaaaaa url(images/ui-bg_flat_0_aaaaaa_40x100.png) 50% 50% repeat-x; opacity: .30;filter:Alpha(Opacity=30); }
250 -.ui-widget-shadow { margin: -8px 0 0 -8px; padding: 8px; background: #aaaaaa url(images/ui-bg_flat_0_aaaaaa_40x100.png) 50% 50% repeat-x; opacity: .30;filter:Alpha(Opacity=30); -moz-border-radius: 8px; -webkit-border-radius: 8px; border-radius: 8px; }
\ No newline at end of file
 247+.ui-widget-overlay, .ui-widget-shadow { /* @embed */ background: #aaaaaa url(images/ui-bg_flat_0_aaaaaa_40x100.png) 50% 50% repeat-x; }
 248+.ui-widget-overlay { opacity: .30;filter:Alpha(Opacity=30); }
 249+.ui-widget-shadow { margin: -8px 0 0 -8px; padding: 8px; opacity: .30;filter:Alpha(Opacity=30); -moz-border-radius: 8px; -webkit-border-radius: 8px; border-radius: 8px; }
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79839(bug 26497) printable=yes and handheld=yes request parameters were broken. Fi...catrope20:22, 7 January 2011
r79862Attempt at fixing bug 26370, which seems to be an infinite loop caused by ob_...catrope15:41, 8 January 2011
r79863Per r79581 CR, add @embed comments to jQuery UI's default theme's CSS too, an...catrope15:54, 8 January 2011
r79895ResourceLoader-ify the Collection extension. This is not a complete cleanup a...catrope13:05, 9 January 2011
r80003Apply array_unique() to module lists in OutputPage, should prevent lots of du...catrope13:41, 11 January 2011
r80005Followup r80003: array_unique() preserves keys, so we got module arrays that ...catrope13:51, 11 January 2011
r80164Remove rtl modes from Print stylesheet, since ResourceLoader now does this it...hartman11:39, 13 January 2011
r80692Fix r80666: botched variable renamecatrope17:23, 21 January 2011

Status & tagging log