r80164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80163‎ | r80164 | r80165 >
Date:11:39, 13 January 2011
Author:hartman
Status:resolved (Comments)
Tags:
Comment:
Remove rtl modes from Print stylesheet, since ResourceLoader now does this itself.

Fixes bug 26694 and relates to r65923
Modified paths:
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/commonPrint.css
@@ -18,12 +18,9 @@
1919 background-color: #f9f9f9;
2020 padding: 5px;
2121 }
22 -body.ltr .tocindent {
 22+.tocindent {
2323 margin-left: 2em;
2424 }
25 -body.rtl .tocindent {
26 - margin-right: 2em;
27 -}
2825 .tocline {
2926 margin-bottom: 0px;
3027 }
@@ -35,11 +32,6 @@
3633 position: relative;
3734 margin: 0.5em 0 0.8em 1.4em;
3835 }
39 -body.rtl div.floatright {
40 - float: left;
41 - clear: left;
42 - margin: 0.5em 1.4em 0.8em 0;
43 -}
4436 div.floatright p {
4537 font-style: italic;
4638 }
@@ -49,11 +41,6 @@
5042 position: relative;
5143 margin: 0.5em 1.4em 0.8em 0;
5244 }
53 -body.rtl div.floatleft {
54 - float: right;
55 - clear: right;
56 - margin: 0.5em 0 0.8em 1.4em;
57 -}
5845 div.floatleft p {
5946 font-style: italic;
6047 }
@@ -84,9 +71,6 @@
8572 padding: 3px !important;
8673 font-size: 94%;
8774 }
88 -body.rtl .thumbcaption {
89 - text-align: right;
90 -}
9175
9276 div.magnify {
9377 display: none;
@@ -101,16 +85,6 @@
10286 clear: left;
10387 margin: 0.5em 1.4em 0.8em 0;
10488 }
105 -body.rtl div.tright {
106 - float: left;
107 - clear: left;
108 - border-width: 0.5em 1.4em 0.8em 0;
109 -}
110 -body.rtl div.tleft {
111 - float: right;
112 - clear: right;
113 - border-width: 0.5em 0 0.8em 1.4em;
114 -}
11589 img.thumbborder {
11690 border: 1px solid #dddddd;
11791 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r80209Follow up r80164. Define explicit direction on content and noflip on image th...hartman23:43, 13 January 2011
r810091.17: MFT r79839, r79862, r79863, r79895, r80003, r80005, r80164, r80692catrope00:20, 26 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65923Improve CSS for print versions...hartman00:08, 5 May 2010

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   23:11, 13 January 2011

I'm having a hard time verifying this is working - I believe this code is correct, but it doesn't seem to be getting applied when I actually print. Were you able to make it work? There may be an issue outside of the CSS that's causing this.

#Comment by TheDJ (talk | contribs)   23:16, 13 January 2011

indeed seems that the print stylesheet is not being flipped for some reason.

#Comment by Trevor Parscal (WMF) (talk | contribs)   23:17, 13 January 2011

Well, upon loading it, I see the rules have been flipped - what I don't see is it being applied to printed output.

#Comment by Catrope (talk | contribs)   02:16, 25 January 2011

That should be fixed now.

Status & tagging log