r79723 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79722‎ | r79723 | r79724 >
Date:15:25, 6 January 2011
Author:reedy
Status:resolved
Tags:
Comment:
Followup r79707, nicer whitespace. Beyond this, I'm beyond caring...
Modified paths:
  • /trunk/phase3/includes/WatchlistEditor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WatchlistEditor.php
@@ -208,13 +208,15 @@
209209 $titles = array();
210210 $dbr = wfGetDB( DB_MASTER );
211211
212 - $res = $dbr->select( array( 'watchlist', 'page' ),
213 - array( 'wl_namespace', 'wl_title', 'page_id', 'page_len', 'page_is_redirect', 'page_latest' ),
214 - array( 'wl_user' => $user->getId() ),
215 - __METHOD__,
216 - $dbr->implicitOrderby() ? array( ) : array( 'ORDER BY' => 'wl_title' ),
217 - array( 'page' => array( 'LEFT JOIN', 'wl_namespace = page_namespace AND wl_title = page_title' ) )
218 - );
 212+ $res = $dbr->select(
 213+ array( 'watchlist', 'page' ),
 214+ array( 'wl_namespace', 'wl_title', 'page_id', 'page_len', 'page_is_redirect', 'page_latest' ),
 215+ array( 'wl_user' => $user->getId() ),
 216+ __METHOD__,
 217+ $dbr->implicitOrderby() ? array( ) : array( 'ORDER BY' => 'wl_title' ),
 218+ array( 'page' =>
 219+ array( 'LEFT JOIN', 'wl_namespace = page_namespace AND wl_title = page_title' ) )
 220+ );
219221
220222 if( $res && $dbr->numRows( $res ) > 0 ) {
221223 $cache = LinkCache::singleton();

Follow-up revisions

RevisionCommit summaryAuthorDate
r84643Follow-up r79723: even nicer whitespace :Dhappy-melon22:29, 23 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79707Fixup raw sql buildingreedy02:51, 6 January 2011

Status & tagging log