r79724 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r79723‎ \| r79724 \| r79725 >
Date:	15:27, 6 January 2011
Author:	reedy
Status:	ok
Tags:
Comment:	Followup r79709, re-add equals Removed due to previous CR, that had not had any response to, so presumed right
Modified paths:	/trunk/phase3/includes/parser/Preprocessor_DOM.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Preprocessor_DOM.php
—	—	@@ -44,7 +44,7 @@
45	45	if ( is_int( $k ) ) {
46	46	$xml .= "<part><name index=\"$k\"/><value>" . htmlspecialchars( $val ) ."</value></part>";
47	47	} else {
48		~~- $xml .= "<part><name>" . htmlspecialchars( $k ) . "</name><value>" . htmlspecialchars( $val ) . "</value></part>";~~
	48	+ $xml .= "<part><name>" . htmlspecialchars( $k ) . "</name>=<value>" . htmlspecialchars( $val ) . "</value></part>";
49	49	}
50	50	}
51	51

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r79709	Fixup fixme on r67819	reedy	03:24, 6 January 2011

Status & tagging log

17:59, 6 January 2011 Platonides (talk | contribs) changed the status of r79724 [removed: new added: ok]