r84643 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84642‎ | r84643 | r84644 >
Date:22:29, 23 March 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r79723: even nicer whitespace :D
Modified paths:
  • /trunk/phase3/includes/WatchlistEditor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WatchlistEditor.php
@@ -212,14 +212,23 @@
213213 $dbr = wfGetDB( DB_MASTER );
214214
215215 $res = $dbr->select(
216 - array( 'watchlist', 'page' ),
217 - array( 'wl_namespace', 'wl_title', 'page_id', 'page_len', 'page_is_redirect', 'page_latest' ),
218 - array( 'wl_user' => $user->getId() ),
219 - __METHOD__,
220 - array( 'ORDER BY' => 'wl_namespace, wl_title' ),
221 - array( 'page' =>
222 - array( 'LEFT JOIN', 'wl_namespace = page_namespace AND wl_title = page_title' ) )
223 - );
 216+ array( 'watchlist', 'page' ),
 217+ array(
 218+ 'wl_namespace',
 219+ 'wl_title',
 220+ 'page_id',
 221+ 'page_len',
 222+ 'page_is_redirect',
 223+ 'page_latest'
 224+ ),
 225+ array( 'wl_user' => $user->getId() ),
 226+ __METHOD__,
 227+ array( 'ORDER BY' => 'wl_namespace, wl_title' ),
 228+ array( 'page' => array(
 229+ 'LEFT JOIN',
 230+ 'wl_namespace = page_namespace AND wl_title = page_title'
 231+ ) )
 232+ );
224233
225234 if( $res && $dbr->numRows( $res ) > 0 ) {
226235 $cache = LinkCache::singleton();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79723Followup r79707, nicer whitespace. Beyond this, I'm beyond caring...reedy15:25, 6 January 2011

Status & tagging log