r79660 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79659‎ | r79660 | r79661 >
Date:19:58, 5 January 2011
Author:btongminh
Status:ok
Tags:
Comment:
Follow-up r79655: array_diff makes in_array unnecessary
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -4119,7 +4119,7 @@
41204120
41214121 $types = $this->exists() ? $wgRestrictionTypes : array( 'create' );
41224122
4123 - if ( $this->getNamespace() != NS_FILE && in_array( 'upload', $types ) ) {
 4123+ if ( $this->getNamespace() != NS_FILE ) {
41244124 $types = array_diff( $types, array( 'upload' ) );
41254125 }
41264126

Follow-up revisions

RevisionCommit summaryAuthorDate
r797201.17: MFT r79578, r79591, r79593, r79595, r79649, r79650, r79651, r79653, r79...catrope14:48, 6 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79655(bug 26574) Added 'upload' to $wgRestrictionTypes, allowing upload protected ...btongminh19:17, 5 January 2011

Status & tagging log