r79595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79594‎ | r79595 | r79596 >
Date:20:04, 4 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Kill some FailFunction remenants
Modified paths:
  • /trunk/extensions/Farmer/MediaWikiFarmer_Wiki.php (modified) (history)
  • /trunk/extensions/Wikidata/Database+scripts/Convenience/Create+wikidata.php (modified) (history)
  • /trunk/extensions/Wikidata/Database+scripts/Incremental/ReadPatch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Farmer/MediaWikiFarmer_Wiki.php
@@ -412,7 +412,7 @@
413413 $user = $farmer->dbAdminUser;
414414 $password = $farmer->dbAdminPassword;
415415 $class = 'Database' . ucfirst( $wgDBtype );
416 - $object = new $class( $wgDBserver, $user, $password, $db, false, 0, $prefix );
 416+ $object = new $class( $wgDBserver, $user, $password, $db, 0, $prefix );
417417 if ( $selectDB )
418418 $this->_db = $object;
419419 return $object;
Index: trunk/extensions/Wikidata/Database scripts/Incremental/ReadPatch.php
@@ -158,7 +158,7 @@
159159 }
160160 # Attempt to connect to the database as a privileged user
161161 # This will vomit up an error if there are permissions problems
162 -$wdDatabase = new $dbclass( $server, $user, $password, $database, 1 );
 162+$wdDatabase = new $dbclass( $server, $user, $password, $database );
163163
164164 if ( !$wdDatabase->isOpen() ) {
165165 # Appears to have failed
Index: trunk/extensions/Wikidata/Database scripts/Convenience/Create wikidata.php
@@ -220,7 +220,7 @@
221221 }
222222 # Attempt to connect to the database as a privileged user
223223 # This will vomit up an error if there are permissions problems
224 -$wdDatabase = new $dbclass( $server, $user, $password, $database, 1 );
 224+$wdDatabase = new $dbclass( $server, $user, $password, $database );
225225
226226 if ( !$wdDatabase->isOpen() ) {
227227 # Appears to have failed

Follow-up revisions

RevisionCommit summaryAuthorDate
r797201.17: MFT r79578, r79591, r79593, r79595, r79649, r79650, r79651, r79653, r79...catrope14:48, 6 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75343(bug 24853) Kill failFunction - Fixed! :Dreedy21:27, 24 October 2010

Status & tagging log