r79661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79660‎ | r79661 | r79662 >
Date:19:58, 5 January 2011
Author:kaldari
Status:deferred
Tags:
Comment:
adding some comments
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -37,7 +37,10 @@
3838 }
3939
4040 /**
41 - * Generate the body for a static Javascript file
 41+ * Generate the body for the Javascript file
 42+ *
 43+ * We use a jsonp scheme for actual delivery of the banner so that they can be served from meta.
 44+ * In order to circumvent the normal squid cache override we add '/cn.js' to the bannerlist URL.
4245 */
4346 function getOutput() {
4447 global $wgCentralPagePath;
@@ -90,7 +93,7 @@
9194 var groomedBannerList = [];
9295
9396 for( var i = 0; i < bannerList.length; i++ ) {
94 - // Only include this banner if it's inteded for the current user
 97+ // Only include this banner if it's intended for the current user
9598 if( ( wgUserName && bannerList[i].display_account ) ||
9699 ( !wgUserName && bannerList[i].display_anon == 1 ) )
97100 {

Status & tagging log