r79591 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79590‎ | r79591 | r79592 >
Date:19:33, 4 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Simplest possible fix for *(bug 26552) ForeignDBRepo broken?

Going to see what other uses I can find of stuff constructing their own Database Instances...
Modified paths:
  • /trunk/phase3/includes/filerepo/ForeignDBRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/ForeignDBRepo.php
@@ -37,7 +37,7 @@
3838 if ( !isset( $this->dbConn ) ) {
3939 $class = 'Database' . ucfirst( $this->dbType );
4040 $this->dbConn = new $class( $this->dbServer, $this->dbUser,
41 - $this->dbPassword, $this->dbName, false, $this->dbFlags,
 41+ $this->dbPassword, $this->dbName, $this->dbFlags,
4242 $this->tablePrefix );
4343 }
4444 return $this->dbConn;

Follow-up revisions

RevisionCommit summaryAuthorDate
r797201.17: MFT r79578, r79591, r79593, r79595, r79649, r79650, r79651, r79653, r79...catrope14:48, 6 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75343(bug 24853) Kill failFunction - Fixed! :Dreedy21:27, 24 October 2010

Status & tagging log