r79498 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79497‎ | r79498 | r79499 >
Date:19:45, 2 January 2011
Author:brion
Status:ok
Tags:
Comment:
* (bug 26537) ExtensionDistributor download fix for Opera

Download was being triggered with an HTTP "Refresh" header in the format:

Refresh: 5;http://example.com/tarballs/foo.tgz

This worked fine in Firefox, but Opera was not picking up the target URL, and ended up refreshing the current page instead.
Turns out there's actually supposed to be a "url=" in front of the URL; with that added, Opera picks it up fine now:

Refresh: 5;url=http://example.com/tarballs/foo.tgz
Modified paths:
  • /trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ExtensionDistributor/ExtensionDistributor_body.php
——@@ -259,7 +259,7 @@
260260 htmlspecialchars( wfMsg( 'extdist-want-more' ) ) . '</a></big></p>' );
261261
262262 // Redirect to the file
263 - header( 'Refresh: 5;' . $url );
 263+ header( 'Refresh: 5;url=' . $url );
264264 }
265265
266266 protected function updateAndGetRevisionLocal( $extension, $version ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r79503Refresh header fix for Opera, as in r79498tstarling02:05, 3 January 2011
r797191.17: MFT r78078, r78285, r78787, r79246, r79358, r79480, r79481, r79491, r79...catrope14:15, 6 January 2011

Status & tagging log