r79481 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79480‎ | r79481 | r79482 >
Date:08:25, 2 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Explicitally define $duplicates = array();

Also changed undefined $row for $rows
Modified paths:
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -311,6 +311,7 @@
312312 $this->output( wfTimestamp( TS_DB ) );
313313 $this->output( "......<b>Found duplicate entries</b>\n" );
314314 $this->output( sprintf( "<b> %-60s %3s %5s</b>\n", 'Title', 'NS', 'Count' ) );
 315+ $duplicate = array();
315316 foreach ( $rows as $row ) {
316317 if ( ! isset( $duplicate[$row->cur_namespace] ) ) {
317318 $duplicate[$row->cur_namespace] = array();
@@ -622,7 +623,7 @@
623624 $rows = $this->db->affectedRows();
624625
625626 if( $rows ) {
626 - $this->output( "Set page_random to a random value on $row rows where it was set to 0\n" );
 627+ $this->output( "Set page_random to a random value on $rows rows where it was set to 0\n" );
627628 } else {
628629 $this->output( "...no page_random rows needed to be set\n" );
629630 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r797191.17: MFT r78078, r78285, r78787, r79246, r79358, r79480, r79481, r79491, r79...catrope14:15, 6 January 2011

Status & tagging log