r78078 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78077‎ | r78078 | r78079 >
Date:17:22, 8 December 2010
Author:demon
Status:ok
Tags:
Comment:
(bug 22753) update.php should make things it actually changed stand out better in its report. Fixed the last update.php entry that isn't clear on when it did something or skipped a step. Now all of the "nothing done" messages should be prefixed by "...". We should probably abstract this somehow.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -617,13 +617,17 @@
618618 * @see bug 3946
619619 */
620620 protected function doPageRandomUpdate() {
621 - $this->output( "Setting page_random to a random value on rows where it equals 0..." );
 621+
622622
623623 $page = $this->db->tableName( 'page' );
624624 $this->db->query( "UPDATE $page SET page_random = RAND() WHERE page_random = 0", __METHOD__ );
625625 $rows = $this->db->affectedRows();
626626
627 - $this->output( "changed $rows rows\n" );
 627+ if( $rows ) {
 628+ $this->output( "Set page_random to a random value on $row rows where it was set to 0\n" );
 629+ } else {
 630+ $this->output( "...no page_random rows needed to be set\n" );
 631+ }
628632 }
629633
630634 protected function doTemplatelinksUpdate() {
Index: trunk/phase3/RELEASE-NOTES
@@ -470,6 +470,8 @@
471471 * (bug 10871) Javascript and CSS pages in MediaWiki namespace are no longer treated
472472 as wikitext on preview.
473473 * (bug 25512) Subcategory list should not include category prefix for members.
 474+* (bug 22753) Output from update.php is more clear when things changed, entries
 475+ indicating nothing changed are now all prefixed by "..."
474476
475477 === API changes in 1.17 ===
476478 * (bug 22738) Allow filtering by action type on query=logevent.

Follow-up revisions

RevisionCommit summaryAuthorDate
r797191.17: MFT r78078, r78285, r78787, r79246, r79358, r79480, r79481, r79491, r79...catrope14:15, 6 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68660Uniformly indent things that have already been completed. Sort of addresses b...demon13:44, 28 June 2010

Status & tagging log