r79011 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r79010‎ | r79011 | r79012 >
Date:23:10, 25 December 2010
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
Skins override shared.css, merged fix for bug 26423 in r79010 to skins instead
Modified paths:
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
——@@ -279,7 +279,8 @@
280280 /* thumbnails */
281281 div.thumb {
282282 margin-bottom: 0.5em;
283 - border-style: solid; border-color: white;
 283+ border-style: solid;
 284+ border-color: transparent;
284285 width: auto;
285286 }
286287 div.thumbinner {
Index: trunk/phase3/skins/monobook/main.css
——@@ -411,7 +411,7 @@
412412 div.thumb {
413413 margin-bottom: .5em;
414414 border-style: solid;
415 - border-color: white;
 415+ border-color: transparent;
416416 width: auto;
417417 }
418418 div.thumbinner {
Index: trunk/phase3/skins/modern/main.css
——@@ -488,7 +488,7 @@
489489 div.thumb {
490490 margin-bottom: .5em;
491491 border-style: solid;
492 - border-color: white;
 492+ border-color: transparent;
493493 width: auto;
494494 }
495495 div.thumbinner {
Index: trunk/phase3/skins/common/shared.css
——@@ -129,12 +129,6 @@
130130 }
131131
132132 /**
133 - * Thumbnails
134 - */
135 -/* Transparent instead of white thumb-containers (prevent white around thumbs on non-white backgrounds/templates) */
136 -div.thumb { border-color: transparent; }
137 -
138 -/**
139133 * Image captions
140134 */
141135 body.rtl .thumbcaption { text-align: right; }
Index: trunk/phase3/skins/vector/screen.css
——@@ -893,7 +893,7 @@
894894 div.thumb {
895895 margin-bottom: .5em;
896896 border-style: solid;
897 - border-color: white;
 897+ border-color: transparent;
898898 width: auto;
899899 background-color: transparent;
900900 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79010Removing ugly whitespace around thumbnails on a non-white background....krinkle22:57, 25 December 2010

Comments

#Comment by Fomafix (talk | contribs)   11:45, 27 December 2010

The most important reason for the white borders around thumbs were the lines under h2 headings. When you do not want to create a white space around the thumbs, then don't use border-width for the margin, use margin.

You can also keep away the lines unter die headings from thumb with 

h1, h2, h3, h4, h5, h6 { overflow:hidden }
#Comment by TheDJ (talk | contribs)   12:45, 27 December 2010

Agreed, this needs further work. Marking as fixme

#Comment by TheDJ (talk | contribs)   19:49, 27 December 2010

Dude, you fixed WP:BUNCH !!!!!!!!!

#Comment by Krinkle (talk | contribs)   23:09, 27 December 2010

See https://bugzilla.wikimedia.org/show_bug.cgi?id=26449

And r79087.

#Comment by Krinkle (talk | contribs)   20:48, 27 December 2010

I didn't introduce the borders. Anyway, changed them to margin in r79086. I've compared the before and afters of each affected skin pixel by pixel and there is no visible difference in either left or right or un-floated.

note: en.wikipedia has been overwriting the border with margin for quite some time in their MediaWiki:Common:css

Status & tagging log