r78499 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78498‎ | r78499 | r78500 >
Date:18:06, 16 December 2010
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Follow-up r78452, r78497: having got my copy of phpunit working, fix test better.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/LicensesTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/LicensesTest.php
——@@ -13,7 +13,7 @@
1414 'type' => 'select',
1515 'section' => 'description',
1616 'id' => 'wpLicense',
17 - 'label-message' => 'license',
 17+ 'label' => 'A label text', # Note can't test label-message because $wgOut is not defined
1818 'name' => 'AnotherName',
1919 'licenses' => $str,
2020 ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78452Clean up the running mess that is r64866, r65040, and then r67277. Implement...happy-melon21:14, 15 December 2010
r78497Follow-up r78452: if you're going to try and declare an HTMLFormField without...happy-melon17:34, 16 December 2010

Comments

#Comment by Platonides (talk | contribs)   18:25, 20 December 2010

The tests should run with $wgOut defined.

Status & tagging log