r67277 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67276‎ | r67277 | r67278 >
Date:09:43, 3 June 2010
Author:happy-melon
Status:reverted (Comments)
Tags:
Comment:
Follow-up to r64903; fix field names broken by r65040.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEmailuser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEmailuser.php
@@ -35,6 +35,7 @@
3636 'id' => 'mw-emailuser-recipient',
3737 ),
3838 'Target' => array(
 39+ 'name' => 'wpTarget',
3940 'type' => 'hidden',
4041 'default' => $this->mTargetObj->getName(),
4142 ),
@@ -133,14 +134,8 @@
134135 wfDebug( "Target is empty.\n" );
135136 return 'notarget';
136137 }
137 -
138 - $nt = Title::newFromURL( $target );
139 - if ( !$nt instanceof Title ) {
140 - wfDebug( "Target is invalid title.\n" );
141 - return 'notarget';
142 - }
143 -
144 - $nu = User::newFromName( $nt->getText() );
 138+
 139+ $nu = User::newFromName( $target );
145140 if( !$nu instanceof User || !$nu->getId() ) {
146141 wfDebug( "Target is invalid user.\n" );
147142 return 'notarget';

Follow-up revisions

RevisionCommit summaryAuthorDate
r78452Clean up the running mess that is r64866, r65040, and then r67277. Implement...happy-melon21:14, 15 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64903Overhaul Special:EmailUser, use HTMLForm, a SpecialPage-derived class, and ge...happy-melon21:14, 10 April 2010
r65040From r64866, more consistent behaviour of hidden field names. May affect r65...happy-melon21:42, 14 April 2010

Comments

#Comment by Happy-melon (talk | contribs)   21:20, 15 December 2010

These changes have been collectively superceded by r78452 and r77714.

Status & tagging log