r78497 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78496‎ | r78497 | r78498 >
Date:17:34, 16 December 2010
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Follow-up r78452: if you're going to try and declare an HTMLFormField without 80% of its parameters, it's probably not surprising that it doesn't like it... :-D
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/LicensesTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/LicensesTest.php
@@ -8,7 +8,15 @@
99 ** GFDL|Debian disagrees
1010 ";
1111
12 - $lc = new Licenses( array( 'licenses' => $str ) );
 12+ $lc = new Licenses( array(
 13+ 'fieldname' => 'FooField',
 14+ 'type' => 'select',
 15+ 'section' => 'description',
 16+ 'id' => 'wpLicense',
 17+ 'label-message' => 'license',
 18+ 'name' => 'AnotherName',
 19+ 'licenses' => $str,
 20+ ) );
1321 $this->assertThat( $lc, $this->isInstanceOf( 'Licenses' ) );
1422 }
1523 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r78499Follow-up r78452, r78497: having got my copy of phpunit working, fix test bet...happy-melon18:06, 16 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78452Clean up the running mess that is r64866, r65040, and then r67277. Implement...happy-melon21:14, 15 December 2010

Comments

#Comment by Platonides (talk | contribs)   19:04, 16 December 2010

Well, it is an odd test (see r73954).

Status & tagging log