r78200 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78199‎ | r78200 | r78201 >
Date:17:21, 10 December 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Make load.php output a comment explaining what's going on when no modules were requested rather than outputting nothing. Max made me do this because he hates blank pages
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoader.php
@@ -409,6 +409,10 @@
410410 public function makeModuleResponse( ResourceLoaderContext $context,
411411 array $modules, $missing = array() )
412412 {
 413+ if ( $modules === array() && $missing === array() ) {
 414+ return '/* No modules requested. Max made me put this here */';
 415+ }
 416+
413417 // Pre-fetch blobs
414418 if ( $context->shouldIncludeMessages() ) {
415419 $blobs = MessageBlobStore::get( $this, $modules, $context->getLanguage() );

Follow-up revisions

RevisionCommit summaryAuthorDate
r798131.17: MFT r78093, r79245, r79570, r79571, r79573, r79574, r79581, r79582, r79...catrope13:20, 7 January 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   21:20, 10 December 2010

Does it have to mention 'Max'?

#Comment by Catrope (talk | contribs)   21:21, 10 December 2010

Someone suggested I put an easter egg here, so... :)

#Comment by Jack Phoenix (talk | contribs)   21:23, 10 December 2010

Partially fixes bug #20281, then. ;-)

#Comment by Emufarmers (talk | contribs)   21:25, 10 December 2010

omg, outing.

#Comment by Trevor Parscal (WMF) (talk | contribs)   23:25, 6 January 2011

Max deserves this.

#Comment by Trevor Parscal (WMF) (talk | contribs)   23:25, 6 January 2011

I mean that in a good way...

#Comment by MZMcBride (talk | contribs)   00:56, 7 January 2011

:D

Status & tagging log