r78093 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78092‎ | r78093 | r78094 >
Date:20:10, 8 December 2010
Author:catrope
Status:ok
Tags:
Comment:
Remove unnecessary check against $wgAllowUserCss in ResourceLoaderUserModule that was used to trigger JS as well as CSS, breaking installs where user JS is allowed but user CSS is not. Callers already check for the relevant $wgAllow* variables before including this module.
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderUserModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderUserModule.php
@@ -28,9 +28,7 @@
2929 /* Protected Methods */
3030
3131 protected function getPages( ResourceLoaderContext $context ) {
32 - global $wgAllowUserCss;
33 -
34 - if ( $context->getUser() && $wgAllowUserCss ) {
 32+ if ( $context->getUser() ) {
3533 $username = $context->getUser();
3634 return array(
3735 "$username/common.js" => array( 'ns' => NS_USER, 'type' => 'script' ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r798131.17: MFT r78093, r79245, r79570, r79571, r79573, r79574, r79581, r79582, r79...catrope13:20, 7 January 2011

Status & tagging log