r79766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79765‎ | r79766 | r79767 >
Date:22:42, 6 January 2011
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Improves on r79582 - no need to delete the rules, just merge them! Do you really want to second-guess why jQuery UI put them there?
Modified paths:
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.theme.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.theme.css
@@ -43,7 +43,7 @@
4444 ----------------------------------*/
4545
4646 /* states and images */
47 -.ui-icon { width: 16px; height: 16px; /* @embed */ background-image: url(images/ui-icons_72a7cf_256x240.png); }
 47+.ui-icon, .ui-widget-content .ui-icon, .ui-widget-header .ui-icon { width: 16px; height: 16px; /* @embed */ background-image: url(images/ui-icons_72a7cf_256x240.png); }
4848 .ui-state-default .ui-icon { /* @embed */ background-image: url(images/ui-icons_3d80b3_256x240.png); }
4949 .ui-state-hover .ui-icon, .ui-state-focus .ui-icon { /* @embed */ background-image: url(images/ui-icons_2694e8_256x240.png); }
5050 .ui-state-active .ui-icon { /* @embed */ background-image: url(images/ui-icons_666666_256x240.png); }

Follow-up revisions

RevisionCommit summaryAuthorDate
r79770Improves on r79766, and thus also r79582 - the original only applied the widt...tparscal22:46, 6 January 2011
r798131.17: MFT r78093, r79245, r79570, r79571, r79573, r79574, r79581, r79582, r79...catrope13:20, 7 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79582Remove two useless CSS rules that would cause one image to be embedded thricecatrope14:28, 4 January 2011

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   22:47, 6 January 2011

Adds width and height to selectors that did not have them before - solved in r79770.

Status & tagging log