r68660 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68659‎ | r68660 | r68661 >
Date:13:44, 28 June 2010
Author:demon
Status:ok
Tags:
Comment:
Uniformly indent things that have already been completed. Sort of addresses bug 22753.
Modified paths:
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/updaters.inc
@@ -434,7 +434,7 @@
435435 global $wgDatabase;
436436 $fname = 'do_watchlist_update';
437437 if ( $wgDatabase->fieldExists( 'watchlist', 'wl_notificationtimestamp' ) ) {
438 - wfOut( "The watchlist table is already set up for email notification.\n" );
 438+ wfOut( "...the watchlist table is already set up for email notification.\n" );
439439 } else {
440440 wfOut( "Adding wl_notificationtimestamp field for email notification management." );
441441 /* ALTER TABLE watchlist ADD (wl_notificationtimestamp varchar(14) binary NOT NULL default '0'); */
@@ -525,7 +525,7 @@
526526 $wgDatabase->freeResult( $res );
527527
528528 if ( in_array( 'binary', $flags ) ) {
529 - wfOut( "$table table has correct $field encoding.\n" );
 529+ wfOut( "...$table table has correct $field encoding.\n" );
530530 } else {
531531 wfOut( "Fixing $field encoding on $table table... " );
532532 $wgDatabase->sourceFile( archive( $patchFile ) );
@@ -706,7 +706,7 @@
707707 $wgDatabase->sourceFile( archive( 'patch-inverse_timestamp.sql' ) );
708708 wfOut( "ok\n" );
709709 } else {
710 - wfOut( "revision timestamp indexes already up to 2005-03-13\n" );
 710+ wfOut( "...revision timestamp indexes already up to 2005-03-13\n" );
711711 }
712712 }
713713
@@ -807,14 +807,14 @@
808808 $wgDatabase->sourceFile( archive( 'patch-drop_img_type.sql' ) );
809809 wfOut( "ok\n" );
810810 } else {
811 - wfOut( "No img_type field in image table; Good.\n" );
 811+ wfOut( "...no img_type field in image table; Good.\n" );
812812 }
813813 }
814814
815815 function do_old_links_update() {
816816 global $wgDatabase;
817817 if ( $wgDatabase->tableExists( 'pagelinks' ) ) {
818 - wfOut( "Already have pagelinks; skipping old links table updates.\n" );
 818+ wfOut( "...have pagelinks; skipping old links table updates.\n" );
819819 } else {
820820 convertLinks(); flush();
821821 }
@@ -837,7 +837,7 @@
838838 global $wgDatabase;
839839 $duper = new UserDupes( $wgDatabase );
840840 if ( $duper->hasUniqueIndex() ) {
841 - wfOut( "Already have unique user_name index.\n" );
 841+ wfOut( "...already have unique user_name index.\n" );
842842 } else {
843843 if ( !$duper->clearDupes() ) {
844844 wfOut( "WARNING: This next step will probably fail due to unfixed duplicates...\n" );
@@ -1081,7 +1081,7 @@
10821082 if ( !$wgDatabase->tableExists( 'profiling' ) ) {
10831083 // Simply ignore
10841084 } elseif ( $wgDatabase->fieldExists( 'profiling', 'pf_memory' ) ) {
1085 - wfOut( "profiling table has pf_memory field.\n" );
 1085+ wfOut( "...profiling table has pf_memory field.\n" );
10861086 } else {
10871087 wfOut( "Adding pf_memory field to table profiling..." );
10881088 $wgDatabase->sourceFile( archive( 'patch-profiling-memory.sql' ) );
@@ -1373,11 +1373,11 @@
13741374
13751375 function rename_eu_wiki_id() {
13761376 global $wgDatabase;
1377 - wfOut( "Renaming eu_wiki_id -> eu_local_id... " );
13781377 if ( $wgDatabase->fieldExists( 'external_user', 'eu_local_id' ) ) {
1379 - wfOut( "already done.\n" );
 1378+ wfOut( "...eu_wiki_id already renamed to eu_local_id.\n" );
13801379 return;
13811380 }
 1381+ wfOut( "Renaming eu_wiki_id -> eu_local_id... " );
13821382 $wgDatabase->sourceFile( archive( 'patch-eu_local_id.sql' ) );
13831383 wfOut( "ok\n" );
13841384 }
@@ -1396,7 +1396,7 @@
13971397
13981398 function do_update_mime_minor_field() {
13991399 if ( update_row_exists( 'mime_minor_length' ) ) {
1400 - wfOut( "*_mime_minor fields are already long enough.\n" );
 1400+ wfOut( "...*_mime_minor fields are already long enough.\n" );
14011401 } else {
14021402 global $wgDatabase;
14031403 wfOut( "Altering all *_mime_minor fields to 100 bytes in size ... " );

Follow-up revisions

RevisionCommit summaryAuthorDate
r78078(bug 22753) update.php should make things it actually changed stand out bette...demon17:22, 8 December 2010

Status & tagging log