r78005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78004‎ | r78005 | r78006 >
Date:20:00, 7 December 2010
Author:mah
Status:reverted (Comments)
Tags:
Comment:
References causing Bug #26244? This should find a way to just use
what Setup.inc already does.
Modified paths:
  • /trunk/phase3/maintenance/tests/parser/parserTest.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/parser/parserTest.inc
——@@ -149,9 +149,9 @@
150150
151151 $wgEnableParserCache = false;
152152 $wgDeferredUpdateList = array();
153 - $wgMemc = &wfGetMainCache();
154 - $messageMemc = &wfGetMessageCacheStorage();
155 - $parserMemc = &wfGetParserCacheStorage();
 153+ $wgMemc = wfGetMainCache();
 154+ $messageMemc = wfGetMessageCacheStorage();
 155+ $parserMemc = wfGetParserCacheStorage();
156156
157157 // $wgContLang = new StubContLang;
158158 $wgUser = new User;

Follow-up revisions

RevisionCommit summaryAuthorDate
r78087Revert r78005, verified that r78009 seems to have fixed the problem.mah19:17, 8 December 2010

Comments

#Comment by Catrope (talk | contribs)   15:13, 8 December 2010

This looks like it's gonna break stuff, and shouldn't be necessary after r78009. Could you try reverting this locally and see if tesla will still work with that? If so, this should be reverted.

#Comment by Catrope (talk | contribs)   15:15, 8 December 2010

The reason I'm saying this is that r69291 did pretty much the same thing and was reverted by the author fairly quickly.

Status & tagging log