r78004 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78003‎ | r78004 | r78005 >
Date:19:58, 7 December 2010
Author:dantman
Status:ok
Tags:
Comment:
Follow up r78003, forgot to make MonoBook use the footericons code.
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -70,23 +70,6 @@
7171 // Suppress warnings to prevent notices about missing indexes in $this->data
7272 wfSuppressWarnings();
7373
74 - // Generate additional footer icons
75 - $footericons = $this->data["footericons"];
76 - // Unset any icons which don't have an image
77 - foreach ( $footericons as $footerIconsKey => &$footerIconsBlock ) {
78 - foreach ( $footerIconsBlock as $footerIconKey => $footerIcon ) {
79 - if ( !is_string($footerIcon) && !isset($footerIcon["src"]) ) {
80 - unset($footerIconsBlock[$footerIconKey]);
81 - }
82 - }
83 - }
84 - // Redo removal of any empty blocks
85 - foreach ( $footericons as $footerIconsKey => &$footerIconsBlock ) {
86 - if ( count($footerIconsBlock) <= 0 ) {
87 - unset($footericons[$footerIconsKey]);
88 - }
89 - }
90 -
9174 $this->html( 'headelement' );
9275 ?><div id="globalWrapper">
9376 <div id="column-content"><div id="content"<?php $this->html("specialpageattributes") ?>>
@@ -183,7 +166,7 @@
184167 </div><!-- end of the left (by default at least) column -->
185168 <div class="visualClear"></div>
186169 <div id="footer"<?php $this->html('userlangattributes') ?>>
187 -<?php foreach ( $footericons as $blockName => $footerIcons ) { ?>
 170+<?php foreach ( $this->getFooterIcons("icononly") as $blockName => $footerIcons ) { ?>
188171 <div id="f-<?php echo htmlspecialchars($blockName); ?>ico">
189172 <?php foreach ( $footerIcons as $icon ) { ?>
190173 <?php echo $this->skin->makeFooterIcon( $icon ); ?>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78003Commit getFooterLinks and getFooterIcons helpers to abstract the common code ...dantman19:45, 7 December 2010

Status & tagging log