r78009 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r78008‎ | r78009 | r78010 >
Date:20:40, 7 December 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Remove the $wgCaches[CACHE_DB] = false; line added in r74552.
It produces an strange failure when going out of ParserTest::setUp() scope.
(eg. $parserMemc becoming back false instead of a FakeMemcached, related to
using a reference in $wgMemc = &wfGetMainCache() )

Can be checked when running phpunit.php includes/ParserOptionsTest.php
See https://bugzilla.wikimedia.org/show_bug.cgi?id=26244#c4

No errors found in sqlite without it.
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/phpunit.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/phpunit.php
——@@ -20,9 +20,6 @@
2121 // Assume UTC for testing purposes
2222 $wgLocaltimezone = 'UTC';
2323
24 -// To prevent tests from failing with SQLite, we need to turn database caching off
25 -$wgCaches[CACHE_DB] = false;
26 -
2724 require_once( 'PHPUnit/Runner/Version.php' );
2825 if( version_compare( PHPUnit_Runner_Version::id(), '3.5.0', '>=' ) ) {
2926 # PHPUnit 3.5.0 introduced a nice autoloader based on class name

Follow-up revisions

RevisionCommit summaryAuthorDate
r78087Revert r78005, verified that r78009 seems to have fixed the problem.mah19:17, 8 December 2010
r780961.17: Merge recent fixes tagged on CodeReview, except for problematic revisio...catrope21:17, 8 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74552Fix PHP warningnikerabbit18:13, 9 October 2010

Comments

#Comment by Reedy (talk | contribs)   20:48, 7 December 2010

Think you've reference the wrong revision :)

#Comment by Catrope (talk | contribs)   21:00, 7 December 2010

If only we had a way to fix those faulty references... oh wait

#Comment by Platonides (talk | contribs)   23:59, 7 December 2010

The right revision was r68544.

Status & tagging log