r77934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77933‎ | r77934 | r77935 >
Date:00:28, 7 December 2010
Author:nimishg
Status:ok (Comments)
Tags:
Comment:
changing http to https
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/owa.tracker-combined-min.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php
@@ -665,7 +665,7 @@
666666
667667 protected function loadOwaJs() {
668668 global $wgOut, $wgScriptPath;
669 - $wgOut->addHeadItem('owa_tracker', '<script type="text/javascript" src="http://owa.wikimedia.org/owa/modules/base/js/owa.tracker-combined-min.js"></script>');
 669+ $wgOut->addHeadItem('owa_tracker', '<script type="text/javascript" src="https://owa.wikimedia.org/owa/modules/base/js/owa.tracker-combined-min.js"></script>');
670670
671671 $wgOut->addHeadItem( 'owa_get_info', '<script type="text/javascript" src="' .
672672 $wgScriptPath .
Index: trunk/extensions/DonationInterface/payflowpro_gateway/owa.tracker-combined-min.js
@@ -8,11 +8,11 @@
99 //<![CDATA[
1010 //OWA.setSetting('debug', true);
1111 // Set base URL
12 -OWA.setSetting('baseUrl', 'http://owa.wikimedia.org/owa/');
 12+OWA.setSetting('baseUrl', 'https://owa.wikimedia.org/owa/');
1313 //OWA.setApiEndpoint('http://analytics.tesla.usability.wikimedia.org/wiki/d/index.php?action=owa&owa_specialAction');
1414 // Create a tracker
1515 OWATracker = new OWA.tracker();
16 -OWATracker.setEndpoint('http://owa.wikimedia.org/owa/');
 16+OWATracker.setEndpoint('https://owa.wikimedia.org/owa/');
1717 OWATracker.setSiteId('d41d8cd98f00b204e9800998ecf8427e');
1818 OWATracker.trackPageView();
1919 OWATracker.trackClicks();

Comments

#Comment by Awjrichards (talk | contribs)   23:48, 13 December 2010

yay https support! but http protocol and/or web-path to OWA should be configurable rather than hard-coded

#Comment by MarkAHershberger (talk | contribs)   02:23, 2 February 2011

Why should the path be anything but https? What harm does it do to force it to https?

#Comment by Awjrichards (talk | contribs)   02:35, 2 February 2011

The real problem is the hard-coded urls and site id. And depending on the user's setup, https may not be an option.

#Comment by MarkAHershberger (talk | contribs)   02:47, 2 February 2011

Could you open a bug for this, then?

Status & tagging log