r77933 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77932‎ | r77933 | r77934 >
Date:23:50, 6 December 2010
Author:reedy
Status:ok
Tags:
Comment:
*(bug 26257) Kill live/notlive status

Also kills off $wgWikiSVN
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.css (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeReleaseNotes.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/SpecialCode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.php
@@ -131,9 +131,6 @@
132132 // Bump the version number every time you change a CodeReview .css/.js file
133133 $wgCodeReviewStyleVersion = 7;
134134
135 -// The name of a repo which represents the code running on this wiki, used to highlight active revisions
136 -$wgWikiSVN = '';
137 -
138135 // If you are running a closed svn, fill the following two lines with the username and password
139136 // of a user allowed to access it. Otherwise, leave it false.
140137 // This is only necessary if using the shell method to access Subversion
Index: trunk/extensions/CodeReview/codereview.css
@@ -134,10 +134,6 @@
135135 color: darkcyan;
136136 }
137137
138 -.mw-codereview-live td {
139 - border-color: #33cc99 !important;
140 -}
141 -
142138 .mw-wordcloud-size-1, .mw-wordcloud-size-2,
143139 .mw-wordcloud-size-3, .mw-wordcloud-size-4,
144140 .mw-wordcloud-size-5, .mw-wordcloud-size-6,
Index: trunk/extensions/CodeReview/ui/SpecialCode.php
@@ -228,11 +228,7 @@
229229
230230 // Note: this function is poorly factored in the parent class
231231 function formatRow( $row ) {
232 - global $wgWikiSVN;
233232 $css = "mw-codereview-status-{$row->cr_status}";
234 - if ( $this->mRepo->getName() == $wgWikiSVN ) {
235 - $css .= " mw-codereview-" . ( $row-> { $this->getDefaultSort() } <= $this->mCurSVN ? 'live' : 'notlive' );
236 - }
237233 $s = "<tr class=\"$css\">\n";
238234 // Some of this stolen from Pager.php...sigh
239235 $fieldNames = $this->getFieldNames();
Index: trunk/extensions/CodeReview/ui/CodeReleaseNotes.php
@@ -2,7 +2,7 @@
33
44 class CodeReleaseNotes extends CodeView {
55 function __construct( $repoName ) {
6 - global $wgRequest, $wgWikiSVN, $IP;
 6+ global $wgRequest, $IP;
77 parent::__construct( $repoName );
88 $this->mRepo = CodeRepository::newFromName( $repoName );
99 $this->mPath = htmlspecialchars( trim( $wgRequest->getVal( 'path' ) ) );
@@ -12,10 +12,6 @@
1313 $this->mPath = preg_replace( '/\/$/', '', $this->mPath ); // kill last slash
1414 $this->mStartRev = $wgRequest->getIntOrNull( 'startrev' );
1515 $this->mEndRev = $wgRequest->getIntOrNull( 'endrev' );
16 - # Default start rev to last live one if possible
17 - if ( !$this->mStartRev && $this->mRepo && $this->mRepo->getName() == $wgWikiSVN ) {
18 - $this->mStartRev = SpecialVersion::getSvnRevision( $IP ) + 1;
19 - }
2016 }
2117
2218 function execute() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41589Add config option $wgWikiSVN, allowing setting a particular repo name which i...mattj05:26, 3 October 2008
r55077Default $wgWikiSVN to false to keep this generic (note this doesn't work WMF ...aaron03:12, 15 August 2009

Status & tagging log