| Index: trunk/extensions/CodeReview/ui/SpecialCode.php |
| — | — | @@ -235,7 +235,7 @@ |
| 236 | 236 | $this->mCurrentRow = $row; # In case formatValue needs to know |
| 237 | 237 | foreach ( $fieldNames as $field => $name ) { |
| 238 | 238 | $value = isset( $row->$field ) ? $row->$field : null; |
| 239 | | - $formatted = strval( $this->formatValue( $field, $value, $row ) ); |
| | 239 | + $formatted = strval( $this->formatValue( $field, $value ) ); |
| 240 | 240 | if ( $formatted == '' ) { |
| 241 | 241 | $formatted = ' '; |
| 242 | 242 | } |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php |
| — | — | @@ -354,6 +354,27 @@ |
| 355 | 355 | } |
| 356 | 356 | } |
| 357 | 357 | |
| | 358 | + // Note: this function is poorly factored in the parent class |
| | 359 | + function formatRow( $row ) { |
| | 360 | + global $wgWikiSVN; |
| | 361 | + $css = "mw-codereview-status-{$row->cr_status}"; |
| | 362 | + $s = "<tr class=\"$css\">\n"; |
| | 363 | + // Some of this stolen from Pager.php...sigh |
| | 364 | + $fieldNames = $this->getFieldNames(); |
| | 365 | + $this->mCurrentRow = $row; # In case formatValue needs to know |
| | 366 | + foreach ( $fieldNames as $field => $name ) { |
| | 367 | + $value = isset( $row->$field ) ? $row->$field : null; |
| | 368 | + $formatted = strval( $this->formatRevValue( $field, $value, $row ) ); |
| | 369 | + if ( $formatted == '' ) { |
| | 370 | + $formatted = ' '; |
| | 371 | + } |
| | 372 | + $class = 'TablePager_col_' . htmlspecialchars( $field ); |
| | 373 | + $s .= "<td class=\"$class\">$formatted</td>\n"; |
| | 374 | + } |
| | 375 | + $s .= "</tr>\n"; |
| | 376 | + return $s; |
| | 377 | + } |
| | 378 | + |
| 358 | 379 | function getTitle() { |
| 359 | 380 | return SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() ); |
| 360 | 381 | } |