r77817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77816‎ | r77817 | r77818 >
Date:18:16, 5 December 2010
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
Change CodeReview notification e-mail subjects from "[MediaWiki] [r12345] Blah" to "MediaWiki r12345 Blah" because I suspect it's those brackets that are causing GMail's thread detection to lump all CR notifications together in one thread.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -138,7 +138,7 @@
139139
140140 'codereview-reply-link' => 'reply',
141141
142 - 'codereview-email-subj' => '[$1] [$2]: New comment added',
 142+ 'codereview-email-subj' => '$1 $2: New comment added',
143143 'codereview-email-body' => 'User "$1" posted a comment on $3.
144144
145145 Full URL: $2
@@ -147,7 +147,7 @@
148148
149149 $4',
150150
151 - 'codereview-email-subj2' => '[$1] [$2]: Follow-up changes',
 151+ 'codereview-email-subj2' => '$1 $2: Follow-up changes',
152152 'codereview-email-body2' => 'User "$1" made follow-up changes to $2.
153153
154154 Full URL for followed up revision: $5
@@ -158,13 +158,13 @@
159159
160160 $4',
161161
162 - 'codereview-email-subj3' => '[$1] [$2]: Revision status changed',
 162+ 'codereview-email-subj3' => '$1 $2: Revision status changed',
163163 'codereview-email-body3' => 'User "$1" changed the status of $2.
164164
165165 Old Status: $3
166166 New Status: $4',
167167
168 - 'codereview-email-subj4' => '[$1] [$2]: New comment added, and revision status changed',
 168+ 'codereview-email-subj4' => '$1 $2: New comment added, and revision status changed',
169169 'codereview-email-body4' => 'User "$1" changed the status of $2.
170170
171171 Old Status: $3

Follow-up revisions

RevisionCommit summaryAuthorDate
r77818Followup r77817, per Bryan's CR and per Raymond on IRC, switch to [Repo Revis...reedy18:24, 5 December 2010
r779041.16wmf4: MFT r77817, r77818catrope20:46, 6 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r12345Hack for plural to produce correct result, 'patch' by elephantusnikerabbit01:00, 2 January 2006

Comments

#Comment by Bryan (talk | contribs)   18:20, 5 December 2010

I would be handy to group by revision though, so how about [$1 $2] ?

Status & tagging log