r77324 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77323‎ | r77324 | r77325 >
Date:12:05, 26 November 2010
Author:reedy
Status:ok
Tags:
Comment:
Fix indenting from r76849, restore fixme removed in r77314

Document insertChunks
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -209,6 +209,13 @@
210210
211211 /**
212212 * Quickie protection against huuuuuuuuge batch inserts
 213+ *
 214+ * @param DatabaseBase $db
 215+ * @param String $table
 216+ * @param Array $data
 217+ * @param string $method
 218+ * @param array $options
 219+ * @return void
213220 */
214221 protected function insertChunks( $db, $table, $data, $method = __METHOD__, $options = array() ) {
215222 $chunkSize = 100;
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -34,7 +34,7 @@
3535 }
3636
3737 $pathForm = $this->showForm();
38 - $wgOut->addHTML( $pathForm );
 38+ $wgOut->addHTML( $pathForm );
3939
4040 // Get the total count across all pages
4141 $dbr = wfGetDB( DB_SLAVE );
@@ -64,7 +64,7 @@
6565 Xml::closeElement( 'form' )
6666 );
6767
68 - $wgOut->addHTML( $pathForm );
 68+ $wgOut->addHTML( $pathForm );
6969 }
7070
7171 function doBatchChange() {
@@ -174,7 +174,7 @@
175175 }
176176 $ret .= "</tr></table></fieldset>" ;
177177
178 - return $ret;
 178+ return $ret;
179179 }
180180
181181 function getPager() {
@@ -212,6 +212,9 @@
213213 }
214214 }
215215
 216+ /**
 217+ * @todo Document
 218+ */
216219 function getSpecializedWhereClause() {
217220 return array();
218221 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76849More of (bug 25899) Show header and footer stuff at both places...reedy23:30, 16 November 2010
r77314Remove unused parameter from getSpecializedWhereClause...reedy23:56, 25 November 2010

Status & tagging log