r76512 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76511‎ | r76512 | r76513 >
Date:11:55, 11 November 2010
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Fix for r76199 and others too: escape messages
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeStatusListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeStatusListView.php
@@ -17,14 +17,14 @@
1818 foreach ( $states as $state ) {
1919 $link = $this->skin->link(
2020 SpecialPage::getTitleFor( 'Code', $name . "/status/$state" ),
21 - wfMsg( "code-status-".$state )
 21+ wfMsgHtml( "code-status-".$state )
2222 );
2323 $table_rows .= "<tr><td class=\"mw-codereview-status-$state\">$link</td>"
24 - . "<td>" . wfMsg( "code-status-desc-" . $state ) . "</td></tr>\n" ;
 24+ . "<td>" . wfMsgHtml( "code-status-desc-" . $state ) . "</td></tr>\n" ;
2525 }
2626 $wgOut->addHTML( '<table class="TablePager">'
27 - . '<tr><th>' . wfMsg( 'code-field-status' ) . '</th>'
28 - . '<th>' . wfMsg( 'code-field-status-description' ) . '</th></tr>'
 27+ . '<tr><th>' . wfMsgHtml( 'code-field-status' ) . '</th>'
 28+ . '<th>' . wfMsgHtml( 'code-field-status-description' ) . '</th></tr>'
2929 . $table_rows
3030 . '</table>'
3131 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76199Fix up status list table header (fu r74833)hashar16:57, 6 November 2010

Comments

#Comment by Nikerabbit (talk | contribs)   12:59, 11 November 2010

Didn't like my suggestions? :)

Status & tagging log