r76199 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76198‎ | r76199 | r76200 >
Date:16:57, 6 November 2010
Author:hashar
Status:resolved (Comments)
Tags:
Comment:
Fix up status list table header (fu r74833)
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeStatusListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -52,6 +52,7 @@
5353 'code-field-user' => 'Commenter',
5454 'code-field-message' => 'Commit summary',
5555 'code-field-status' => 'Status',
 56+ 'code-field-status-description' => 'Status description',
5657 'code-field-timestamp' => 'Date',
5758 'code-field-comments' => 'Notes',
5859 'code-field-path' => 'Path',
@@ -89,7 +90,7 @@
9091 'code-status-fixme' => 'fixme',
9192 'code-status-desc-fixme' => 'A reviewer marked this revision introduce a bug or is broken. It should be corrected.',
9293 'code-status-reverted' => 'reverted',
93 - 'code-status-desc-reverted' => 'Revision was thrown away by a later revision.',
 94+ 'code-status-desc-reverted' => 'Revision was undone by a later revision.',
9495 'code-status-resolved' => 'resolved',
9596 'code-status-desc-resolved' => 'Revision had an issue which was addressed by a later revision.',
9697 'code-status-ok' => 'ok',
Index: trunk/extensions/CodeReview/ui/CodeStatusListView.php
@@ -23,7 +23,8 @@
2424 . "<td>" . wfMsg( "code-status-desc-" . $state ) . "</td></tr>\n" ;
2525 }
2626 $wgOut->addHTML( '<table class="TablePager">'
27 - . '<tr><th>toto</th><th>tata</th></tr>'
 27+ . '<tr><th>' . wfMsg( 'code-field-status' ) . '</th>'
 28+ . '<th>' . wfMsg( 'code-field-status-description' ) . '</th></tr>'
2829 . $table_rows
2930 . '</table>'
3031 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r76512Fix for r76199 and others too: escape messagesialex11:55, 11 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74833Show a description for each statushashar14:31, 16 October 2010

Comments

#Comment by Nikerabbit (talk | contribs)   17:20, 6 November 2010

New unescaped messages should be avoided. Here one could use wfMessage( 'key' )->escaped(); (or if this needs to be merged into wmf before general code update, wfMsgExt( 'key', array( 'parsemag', 'escape' ) );

Status & tagging log