| Index: trunk/extensions/CodeReview/CodeReview.i18n.php |
| — | — | @@ -84,13 +84,21 @@ |
| 85 | 85 | 'code-rev-total' => 'Total number of results: $1', |
| 86 | 86 | 'code-rev-not-found' => "Revision '''$1''' does not exist!", |
| 87 | 87 | 'code-status-new' => 'new', |
| | 88 | + 'code-status-desc-new' => 'Revision is pending an action (default status).', |
| 88 | 89 | 'code-status-fixme' => 'fixme', |
| | 90 | + 'code-status-desc-fixme' => 'A reviewer marked this revision introduce a bug or is broken. It should be corrected.', |
| 89 | 91 | 'code-status-reverted' => 'reverted', |
| | 92 | + 'code-status-desc-reverted' => 'Revision was thrown away by a later revision.', |
| 90 | 93 | 'code-status-resolved' => 'resolved', |
| | 94 | + 'code-status-desc-resolved' => 'Revision had an issue which got adressed by a later revision.', |
| 91 | 95 | 'code-status-ok' => 'ok', |
| | 96 | + 'code-status-desc-ok' => 'Revision fully reviewed and reviewer is sure it is fine in every way.', |
| 92 | 97 | 'code-status-verified' => 'verified', |
| | 98 | + 'code-status-desc-verified' => 'Revision has been tested and is working as intended.', |
| 93 | 99 | 'code-status-deferred' => 'deferred', |
| | 100 | + 'code-status-desc-deferred' => 'Nobody care about this revision.', |
| 94 | 101 | 'code-status-old' => 'old', |
| | 102 | + 'code-status-desc-old' => 'Old revision with potential bugs but which are not worth the effort of reviewing them.', |
| 95 | 103 | 'code-pathsearch-legend' => 'Search revisions in this repo by path', |
| 96 | 104 | 'code-pathsearch-path' => 'Path:', |
| 97 | 105 | 'code-pathsearch-filter' => 'Filter applied:', |
| Index: trunk/extensions/CodeReview/ui/CodeStatusListView.php |
| — | — | @@ -11,10 +11,21 @@ |
| 12 | 12 | global $wgOut; |
| 13 | 13 | $name = $this->mRepo->getName(); |
| 14 | 14 | $states = CodeRevision::getPossibleStates(); |
| 15 | | - $text = "== " . wfMsg ( "code-field-status" ) . " ==\n"; |
| | 15 | + $wgOut->addWikiText( "== " . wfMsg ( "code-field-status" ) . " ==\n" ); |
| | 16 | + |
| | 17 | + $table_rows = ''; |
| 16 | 18 | foreach ( $states as $state ) { |
| 17 | | - $text .= "* [[Special:Code/$name/status/$state|" . wfMsg ( "code-status-" . $state ) . "]]\n"; |
| | 19 | + $link = $this->mSkin->link( |
| | 20 | + SpecialPage::getTitleFor( 'Code', $name . "/status/$state" ), |
| | 21 | + wfMsg( "code-status-".$state ) |
| | 22 | + ); |
| | 23 | + $table_rows .= "<tr><td>$link</td>" |
| | 24 | + . "<td>" . wfMsg( "code-status-desc-" . $state ) . "</td></tr>\n" ; |
| 18 | 25 | } |
| 19 | | - $wgOut->addWikiText( $text ); |
| | 26 | + $wgOut->addHTML( '<table class="TablePager">' |
| | 27 | + . '<tr><th>toto</th><th>tata</th></tr>' |
| | 28 | + . $table_rows |
| | 29 | + . '</table>' |
| | 30 | + ); |
| 20 | 31 | } |
| 21 | 32 | } |