r74834 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74833‎ | r74834 | r74835 >
Date:14:39, 16 October 2010
Author:hashar
Status:ok
Tags:
Comment:
* CSS class for status can now be used on all elements.
* Stop styling the whole line in 'stat' and 'status' views tables.
Modified paths:
  • /trunk/extensions/CodeReview/codereview.css (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRepoStatsView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeStatusListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/codereview.css
@@ -42,44 +42,56 @@
4343 padding-left: 48px;
4444 }
4545
 46+.mw-codereview-status-new,
4647 .mw-codereview-status-new td {
4748 background: #ffffc0 !important;
4849 }
 50+
 51+.mw-codereview-status-new:hover,
4952 .mw-codereview-status-new:hover td {
5053 background: #dfdfa0 !important;
5154 }
5255
 56+.mw-codereview-status-fixme,
5357 .mw-codereview-status-fixme td {
5458 background: #ff9999 !important;
5559 }
 60+.mw-codereview-status-fixme:hover,
5661 .mw-codereview-status-fixme:hover td {
5762 background: #df0000 !important;
5863 color: white;
5964 }
 65+.mw-codereview-status-fixme:hover a,
6066 .mw-codereview-status-fixme:hover td a {
6167 color: #ff0 !important;
6268 }
6369
 70+.mw-codereview-status-resolved,
6471 .mw-codereview-status-resolved td {
6572 background: #c0ffc0 !important;
6673 }
 74+.mw-codereview-status-resolved:hover,
6775 .mw-codereview-status-resolved:hover td {
6876 background: #a0dfa0 !important;
6977 }
7078
 79+.mw-codereview-status-reverted,
7180 .mw-codereview-status-reverted td {
7281 background: #ddd !important;
7382 color: #666 !important;
7483 text-decoration: line-through !important;
7584 }
 85+.mw-codereview-status-reverted:hover,
7686 .mw-codereview-status-reverted:hover td {
7787 background: #aaa !important;
7888 text-decoration: line-through !important;
7989 }
 90+.mw-codereview-status-deferred,
8091 .mw-codereview-status-deferred td {
8192 color: #666;
8293 }
8394
 95+.mw-codereview-status-old,
8496 .mw-codereview-status-old td {
8597 color: #666;
8698 }
Index: trunk/extensions/CodeReview/ui/CodeStatusListView.php
@@ -19,7 +19,7 @@
2020 SpecialPage::getTitleFor( 'Code', $name . "/status/$state" ),
2121 wfMsg( "code-status-".$state )
2222 );
23 - $table_rows .= "<tr><td>$link</td>"
 23+ $table_rows .= "<tr><td class=\"mw-codereview-status-$state\">$link</td>"
2424 . "<td>" . wfMsg( "code-status-desc-" . $state ) . "</td></tr>\n" ;
2525 }
2626 $wgOut->addHTML( '<table class="TablePager">'
Index: trunk/extensions/CodeReview/ui/CodeRepoStatsView.php
@@ -35,8 +35,8 @@
3636 SpecialPage::getTitleFor( 'Code', $repoName . '/status/' . $state ),
3737 htmlspecialchars( $this->statusDesc( $state ) )
3838 );
39 - $wgOut->addHTML( "<tr class=\"mw-codereview-status-$state\"><td>$link</td>"
40 - . "<td>$count</td></tr>" );
 39+ $wgOut->addHTML( "<tr><td>$link</td>"
 40+ . "<td class=\"mw-codereview-status-$state\">$count</td></tr>" );
4141 }
4242 $wgOut->addHTML( '</table>' );
4343 }
@@ -58,4 +58,4 @@
5959 $wgOut->addHTML( '</table>' );
6060 }
6161 }
62 -}
\ No newline at end of file
 62+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r74835Follow up r74834. Bump wgCodeReviewStyleVersion.hashar15:04, 16 October 2010

Status & tagging log