r71330 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71329‎ | r71330 | r71331 >
Date:06:19, 20 August 2010
Author:werdna
Status:reverted (Comments)
Tags:
Comment:
Apply hack from 1.16wmf4 in r71329 to trunk (follow-up to r71327). The version in r71327 breaks special pages.
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -258,7 +258,9 @@
259259 }
260260
261261 # Sometimes a language will be localised but not actually exist on this wiki.
262 - $validNamespaces = MWNamespace::getValidNamespaces();
 262+ global $wgCanonicalNamespaceNames;
 263+ $validNamespaces = array_keys($wgCanonicalNamespaceNames);
 264+ $validNamespaces[] = NS_MAIN;
263265 foreach( $this->namespaceNames as $key => $text ) {
264266 if ( ! in_array( $key, $validNamespaces ) ) {
265267 unset( $this->namespaceNames[$key] );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71327(bug 24837) Fix issue where namespaces which were localised but not defined w...werdna05:32, 20 August 2010
r71329Follow-up to r71328, turns out from testing on test.wikipedia.org that MWName...werdna05:43, 20 August 2010

Comments

#Comment by 😂 (talk | contribs)   13:19, 7 February 2011

Since the correct getValidNamespaces() is in REL1_17, can't this be reverted?

#Comment by 😂 (talk | contribs)   03:34, 8 February 2011

Was reverted as part of r71342

Status & tagging log