r71329 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71328‎ | r71329 | r71330 >
Date:05:43, 20 August 2010
Author:werdna
Status:ok
Tags:
Comment:
Follow-up to r71328, turns out from testing on test.wikipedia.org that MWNamespace::getValidNamespaces() as used in r71327 does not exist yet in 1.16wmf4.
Modified paths:
  • /branches/wmf/1.16wmf4/languages/Language.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/languages/Language.php
@@ -258,7 +258,10 @@
259259 }
260260
261261 # Sometimes a language will be localised but not actually exist on this wiki.
262 - $validNamespaces = MWNamespace::getValidNamespaces();
 262+ # Hacked to work with 1.16wmf4 by Andrew, 2010-08-20
 263+ global $wgCanonicalNamespaceNames;
 264+ $validNamespaces = array_keys($wgCanonicalNamespaceNames);
 265+ $validNamespaces[] = NS_MAIN;
263266 foreach( $this->namespaceNames as $key => $text ) {
264267 if ( ! in_array( $key, $validNamespaces ) ) {
265268 unset( $this->namespaceNames[$key] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r71330Apply hack from 1.16wmf4 in r71329 to trunk (follow-up to r71327). The versio...werdna06:19, 20 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71327(bug 24837) Fix issue where namespaces which were localised but not defined w...werdna05:32, 20 August 2010
r71328Merge r71327, fix for Language::getNamespaces bug exposed by localising Liqui...werdna05:36, 20 August 2010

Status & tagging log