r71328 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71327‎ | r71328 | r71329 >
Date:05:36, 20 August 2010
Author:werdna
Status:ok
Tags:
Comment:
Merge r71327, fix for Language::getNamespaces bug exposed by localising LiquidThreads namespaces
Modified paths:
  • /branches/wmf/1.16wmf4/languages/Language.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/languages/Language.php
@@ -256,6 +256,14 @@
257257 $this->namespaceNames[NS_PROJECT_TALK] =
258258 $this->fixVariableInNamespace( $talk );
259259 }
 260+
 261+ # Sometimes a language will be localised but not actually exist on this wiki.
 262+ $validNamespaces = MWNamespace::getValidNamespaces();
 263+ foreach( $this->namespaceNames as $key => $text ) {
 264+ if ( ! in_array( $key, $validNamespaces ) ) {
 265+ unset( $this->namespaceNames[$key] );
 266+ }
 267+ }
260268
261269 # The above mixing may leave namespaces out of canonical order.
262270 # Re-order by namespace ID number...
Property changes on: branches/wmf/1.16wmf4/languages/Language.php
___________________________________________________________________
Added: svn:mergeinfo
263271 Merged /trunk/phase3/languages/Language.php:r63545-63546,63549,63643,63764,63897-63901,64113,64509,65387,65391,65555,65590,65650,65816,66591,71327
264272 Merged /branches/wmf-deployment/languages/Language.php:r60970

Follow-up revisions

RevisionCommit summaryAuthorDate
r71329Follow-up to r71328, turns out from testing on test.wikipedia.org that MWName...werdna05:43, 20 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71327(bug 24837) Fix issue where namespaces which were localised but not defined w...werdna05:32, 20 August 2010

Status & tagging log