r70531 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70530‎ | r70531 | r70532 >
Date:23:48, 5 August 2010
Author:kaldari
Status:resolved (Comments)
Tags:
Comment:
switching some hard-coded text to localizable for CentralNotice
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/SpecialCentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialCentralNotice.php
@@ -1355,7 +1355,7 @@
13561356 );
13571357 $htmlOut .= Xml::tags( 'div',
13581358 array( 'style' => 'margin-top: 0.2em;' ),
1359 - '<img src="'.$scriptPath.'/arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-select' ) . ': <a href="#" onclick="selectLanguages(true);return false;">All</a>, <a href="#" onclick="selectLanguages(false);return false;">None</a>, <a href="#" onclick="top10Languages();return false;">Top 10 Languages</a>'
 1359+ '<img src="'.$scriptPath.'/arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-select' ) . ': <a href="#" onclick="selectLanguages(true);return false;">' . wfMsg( 'powersearch-toggleall' ) . '</a>, <a href="#" onclick="selectLanguages(false);return false;">' . wfMsg( 'powersearch-togglenone' ) . '</a>, <a href="#" onclick="top10Languages();return false;">' . wfMsg( 'centralnotice-top-ten-languages' ) . '</a>'
13601360 );
13611361 } else {
13621362 $htmlOut .= Xml::tags( 'select',
Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -59,6 +59,7 @@
6060 'centralnotice-min' => 'Minute',
6161 'centralnotice-project-lang' => 'Project language',
6262 'centralnotice-select' => 'Select',
 63+ 'centralnotice-top-ten-languages' => 'Top 10 Languages',
6364 'centralnotice-project-name' => 'Project name',
6465 'centralnotice-start-date' => 'Start date',
6566 'centralnotice-start-time' => 'Start time (UTC)',

Follow-up revisions

RevisionCommit summaryAuthorDate
r70542Follow-up r70531: Consistent casingraymond06:05, 6 August 2010
r70644moving all colons to message file per comments at r70529 and r70531kaldari19:41, 7 August 2010
r70778localization improvements per comments at r70529 and r70531kaldari20:25, 9 August 2010

Comments

#Comment by Siebrand (talk | contribs)   12:10, 7 August 2010

Contains hard coded colons.

#Comment by Ryan Kaldari (WMF) (talk | contribs)   20:30, 9 August 2010

fixed in r70644 - moved colons to messages

#Comment by MZMcBride (talk | contribs)   05:49, 9 August 2010

The really long line is annoying. If there's a way to break it up into multiple lines, that'd be better.

#Comment by Ryan Kaldari (WMF) (talk | contribs)   20:31, 9 August 2010

fixed in r70778

Status & tagging log