r70644 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70643‎ | r70644 | r70645 >
Date:19:41, 7 August 2010
Author:kaldari
Status:ok
Tags:
Comment:
moving all colons to message file per comments at r70529 and r70531
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/SpecialCentralNotice.php (modified) (history)
  • /trunk/extensions/CentralNotice/SpecialNoticeTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialCentralNotice.php
@@ -757,7 +757,7 @@
758758
759759 if ( $row ) {
760760 // Build Html
761 - $htmlOut .= Xml::tags( 'h2', null, wfMsg( 'centralnotice-notice' ) . ': ' . $notice );
 761+ $htmlOut .= Xml::tags( 'h2', null, wfMsg( 'centralnotice-notice-heading', $notice ) );
762762 $htmlOut .= Xml::openElement( 'table', array( 'cellpadding' => 9 ) );
763763
764764 // Rows
@@ -1348,7 +1348,7 @@
13491349 );
13501350 $htmlOut .= Xml::tags( 'div',
13511351 array( 'style' => 'margin-top: 0.2em;' ),
1352 - '<img src="'.$scriptPath.'/up-arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-select' ) . ': <a href="#" onclick="selectLanguages(true);return false;">' . wfMsg( 'powersearch-toggleall' ) . '</a>, <a href="#" onclick="selectLanguages(false);return false;">' . wfMsg( 'powersearch-togglenone' ) . '</a>, <a href="#" onclick="top10Languages();return false;">' . wfMsg( 'centralnotice-top-ten-languages' ) . '</a>'
 1352+ '<img src="'.$scriptPath.'/up-arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-select' ) . ' <a href="#" onclick="selectLanguages(true);return false;">' . wfMsg( 'powersearch-toggleall' ) . '</a>, <a href="#" onclick="selectLanguages(false);return false;">' . wfMsg( 'powersearch-togglenone' ) . '</a>, <a href="#" onclick="top10Languages();return false;">' . wfMsg( 'centralnotice-top-ten-languages' ) . '</a>'
13531353 );
13541354 } else {
13551355 $htmlOut .= Xml::tags( 'select',
Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -39,10 +39,12 @@
4040 'centralnotice-english' => 'English',
4141 'centralnotice-banner-name' => 'Banner name',
4242 'centralnotice-banner' => 'Banner',
 43+ 'centralnotice-banner-heading' => 'Banner: $1',
4344 'centralnotice-templates' => 'Banners',
4445 'centralnotice-weight' => 'Weight',
4546 'centralnotice-locked' => 'Locked',
4647 'centralnotice-notice' => 'Campaign',
 48+ 'centralnotice-notice-heading' => 'Campaign: $1',
4749 'centralnotice-notices' => 'Campaigns',
4850 'centralnotice-notice-exists' => 'Campaign already exists.
4951 Not adding.',
@@ -60,7 +62,7 @@
6163 'centralnotice-hours' => 'Hour',
6264 'centralnotice-min' => 'Minute',
6365 'centralnotice-project-lang' => 'Project language',
64 - 'centralnotice-select' => 'Select',
 66+ 'centralnotice-select' => 'Select: ',
6567 'centralnotice-top-ten-languages' => 'Top 10 languages',
6668 'centralnotice-project-name' => 'Project name',
6769 'centralnotice-start-date' => 'Start date',
@@ -97,9 +99,9 @@
98100 'centralnotice-message-not-set' => 'Message not set',
99101 'centralnotice-clone' => 'Clone',
100102 'centralnotice-clone-notice' => 'Create a copy of the banner',
101 - 'centralnotice-clone-name' => 'Name',
 103+ 'centralnotice-clone-name' => 'Name:',
102104 'centralnotice-preview-all-template-translations' => 'Preview all available translations of banner',
103 - 'centralnotice-insert' => 'Insert',
 105+ 'centralnotice-insert' => 'Insert:',
104106 'centralnotice-hide-button' => 'Hide button',
105107 'centralnotice-collapse-button' => 'Collapse button',
106108 'centralnotice-expand-button' => 'Expand button',
Index: trunk/extensions/CentralNotice/SpecialNoticeTemplate.php
@@ -198,7 +198,7 @@
199199 $htmlOut .= wfMsg( 'centralnotice-edit-template-summary' );
200200 $htmlOut .= Xml::tags( 'div',
201201 array( 'style' => 'margin-bottom: 0.2em;' ),
202 - '<img src="'.$scriptPath.'/down-arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-insert' ) . ': <a href="#" onclick="insertButton(\'hide\');return false;">' . wfMsg( 'centralnotice-hide-button' ) . '</a>, <a href="#" onclick="insertButton(\'translate\');return false;">' . wfMsg( 'centralnotice-translate-button' ) . '</a>'
 202+ '<img src="'.$scriptPath.'/down-arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-insert' ) . ' <a href="#" onclick="insertButton(\'hide\');return false;">' . wfMsg( 'centralnotice-hide-button' ) . '</a>, <a href="#" onclick="insertButton(\'translate\');return false;">' . wfMsg( 'centralnotice-translate-button' ) . '</a>'
203203 );
204204 $htmlOut .= Xml::textarea( 'templateBody', '', 60, 20 );
205205 $htmlOut .= Xml::closeElement( 'fieldset' );
@@ -244,7 +244,7 @@
245245 // Begin View Banner fieldset
246246 $htmlOut .= Xml::openElement( 'fieldset', array( 'class' => 'prefsection' ) );
247247
248 - $htmlOut .= Xml::element( 'h2', null, wfMsg( 'centralnotice-banner' ) . ': ' . $currentTemplate );
 248+ $htmlOut .= Xml::element( 'h2', null, wfMsg( 'centralnotice-banner-heading', $currentTemplate ) );
249249
250250 // Show preview of banner
251251 $render = new SpecialNoticeText();
@@ -398,7 +398,7 @@
399399 $htmlOut .= wfMsg( 'centralnotice-edit-template-summary' );
400400 $htmlOut .= Xml::tags( 'div',
401401 array( 'style' => 'margin-bottom: 0.2em;' ),
402 - '<img src="'.$scriptPath.'/down-arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-insert' ) . ': <a href="#" onclick="insertButton(\'hide\');return false;">' . wfMsg( 'centralnotice-hide-button' ) . '</a>, <a href="#" onclick="insertButton(\'translate\');return false;">' . wfMsg( 'centralnotice-translate-button' ) . '</a>'
 402+ '<img src="'.$scriptPath.'/down-arrow.png" style="vertical-align:baseline;"/>' . wfMsg( 'centralnotice-insert' ) . ' <a href="#" onclick="insertButton(\'hide\');return false;">' . wfMsg( 'centralnotice-hide-button' ) . '</a>, <a href="#" onclick="insertButton(\'translate\');return false;">' . wfMsg( 'centralnotice-translate-button' ) . '</a>'
403403 );
404404 $htmlOut .= Xml::textarea( 'templateBody', $body, 60, 20, $readonly );
405405 if ( $this->editable ) {
@@ -425,7 +425,7 @@
426426 $htmlOut .= Xml::fieldset( wfMsg( 'centralnotice-clone-notice' ) );
427427 $htmlOut .= Xml::openElement( 'table', array( 'cellpadding' => 9 ) );
428428 $htmlOut .= Xml::openElement( 'tr' );
429 - $htmlOut .= Xml::inputLabel( wfMsg( 'centralnotice-clone-name' ) . ':', 'newTemplate', 'newTemplate', '25' );
 429+ $htmlOut .= Xml::inputLabel( wfMsg( 'centralnotice-clone-name' ), 'newTemplate', 'newTemplate', '25' );
430430 $htmlOut .= Xml::submitButton( wfMsg( 'centralnotice-clone' ), array ( 'id' => 'clone' ) );
431431 $htmlOut .= Xml::hidden( 'oldTemplate', $currentTemplate );
432432
@@ -461,7 +461,7 @@
462462 // Begin View Banner fieldset
463463 $htmlOut .= Xml::openElement( 'fieldset', array( 'class' => 'prefsection' ) );
464464
465 - $htmlOut .= Xml::element( 'h2', null, wfMsg( 'centralnotice-banner' ) . ': ' . $template );
 465+ $htmlOut .= Xml::element( 'h2', null, wfMsg( 'centralnotice-banner-heading', $template ) );
466466
467467 foreach ( $langs as $lang ) {
468468 // Link and Preview all available translations

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70529some interface/localization clean-up for CentralNoticekaldari23:24, 5 August 2010
r70531switching some hard-coded text to localizable for CentralNoticekaldari23:48, 5 August 2010

Status & tagging log