r70532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70531‎ | r70532 | r70533 >
Date:23:58, 5 August 2010
Author:mah
Status:ok (Comments)
Tags:
Comment:
update ParserTestSuiteBackend to match signature on setupRecorder()
Modified paths:
  • /trunk/phase3/maintenance/tests/ParserHelpers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/ParserHelpers.php
@@ -12,10 +12,10 @@
1313 function count() { return 1; }
1414
1515 public function run( PHPUnit_Framework_TestResult $result = null ) {
16 - PHPUnit_Framework_Assert::resetCount();
17 - if ( $result === NULL ) {
18 - $result = new PHPUnit_Framework_TestResult;
19 - }
 16+ PHPUnit_Framework_Assert::resetCount();
 17+ if ( $result === NULL ) {
 18+ $result = new PHPUnit_Framework_TestResult;
 19+ }
2020
2121 $backend = $this->suite->getBackend();
2222 $result->startTest( $this );
@@ -24,12 +24,12 @@
2525 $r = false;
2626 try {
2727 # Run the test.
28 - # On failure, the subclassed backend will throw an exception with
 28+ # On failure, the subclassed backend will throw an exception with
2929 # the details.
3030 $r = $backend->runTest(
3131 $this->test['test'],
32 - $this->test['input'],
33 - $this->test['result'],
 32+ $this->test['input'],
 33+ $this->test['result'],
3434 $this->test['options'],
3535 $this->test['config']
3636 );
@@ -71,7 +71,7 @@
7272 PHPUnit_Framework_Assert::assertEquals( $expected, $got, $desc );
7373 }
7474
75 - public function setupRecorder() {
 75+ public function setupRecorder( $options ) {
7676 $this->recorder = new PHPUnitTestRecorder( $this );
7777 }
7878 }

Comments

#Comment by MarkAHershberger (talk | contribs)   00:02, 6 August 2010

also fixed space-for-tab issues from r68544

Status & tagging log