r70140 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70139‎ | r70140 | r70141 >
Date:15:20, 29 July 2010
Author:jeroendedauw
Status:resolved (Comments)
Tags:
Comment:
Removed showStatusMessage from the Installer and WebInstaller classes as it's only used in the CliInstaller
Modified paths:
  • /trunk/phase3/includes/installer/CliInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -884,15 +884,6 @@
885885 }
886886 }
887887
888 - public function showStatusMessage( $status ) {
889 - $text = $status->getWikiText();
890 - $this->output->addWikiText(
891 - "<div class=\"config-message\">\n" .
892 - $text .
893 - "</div>"
894 - );
895 - }
896 -
897888 /**
898889 * Convenience function to set variables based on form data.
899890 * Assumes that variables containing "password" in the name are (potentially
Index: trunk/phase3/includes/installer/Installer.php
@@ -98,13 +98,6 @@
9999 * output format such as HTML or text before being sent to the user.
100100 */
101101 public abstract function showMessage( $msg /*, ... */ );
102 -
103 - /**
104 - * TODO: doucment
105 - *
106 - * @param $status
107 - */
108 - public abstract function showStatusMessage( $status );
109102
110103 /**
111104 * Constructor, always call this from child classes.
Index: trunk/phase3/includes/installer/CliInstaller.php
@@ -96,7 +96,7 @@
9797 flush();
9898 }
9999
100 - public function showStatusMessage( $status ) {
 100+ public function showStatusMessage( Status $status ) {
101101 $this->showMessage( $status->getWikiText() );
102102 }
103103

Follow-up revisions

RevisionCommit summaryAuthorDate
r70146Follow up to r70140jeroendedauw17:54, 29 July 2010

Comments

#Comment by 😂 (talk | contribs)   15:25, 29 July 2010

We don't use it now but me might. No reason to kill it.

#Comment by Jeroen De Dauw (talk | contribs)   15:29, 29 July 2010

Re-implement it in the CoreInstaller if you want, but having it in Installer made no sense.

#Comment by 😂 (talk | contribs)   17:47, 29 July 2010

Then please move it to CoreInstaller.

#Comment by Jeroen De Dauw (talk | contribs)   17:56, 29 July 2010

Made the change, although I don't agree with "We don't use it now but me might, so let's keep it".

Status & tagging log