r70139 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70138‎ | r70139 | r70140 >
Date:15:02, 29 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Work on repository and package definitions
Modified paths:
  • /trunk/extensions/Deployment/includes/ExtensionInstaller.php (modified) (history)
  • /trunk/extensions/Deployment/includes/PackageDescriptiorProcessor.php (deleted) (history)
  • /trunk/extensions/Deployment/includes/PackageDescriptorParser.php (added) (history)
  • /trunk/extensions/Deployment/includes/PackageDescriptorProcessor.php (added) (history)
  • /trunk/extensions/Deployment/includes/PackageRepository.php (modified) (history)
  • /trunk/extensions/Deployment/includes/filesystems/DirectFilesystem.php (modified) (history)
  • /trunk/extensions/Deployment/includes/filesystems/FtpFilesystem.php (modified) (history)
  • /trunk/extensions/Deployment/includes/filesystems/Ssh2Filesystem.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/includes/PackageDescriptiorProcessor.php
@@ -1,22 +0,0 @@
2 -<?php
3 -
4 -/**
5 - * File holding the PackageDescriptorProcessor class.
6 - * Partly based on DeployDescriptorProcessor from Ontoprises Deployment Framework.
7 - *
8 - * @file PackageDescriptorProcessor.php
9 - * @ingroup Deployment
10 - *
11 - * @author Jeroen De Dauw
12 - * @author Kai Kühn
13 - */
14 -
15 -/**
16 - * Package description processing class.
17 - *
18 - * @author Jeroen De Dauw
19 - * @author Kai Kühn
20 - */
21 -class PackageDescriptorProcessor {
22 -
23 -}
\ No newline at end of file
Index: trunk/extensions/Deployment/includes/ExtensionInstaller.php
@@ -20,9 +20,11 @@
2121
2222
2323 /**
24 - * Constructor
 24+ * Constructor.
2525 */
2626 public function __construct() {
 27+ parent::__construct();
 28+
2729 // TODO
2830 }
2931
Index: trunk/extensions/Deployment/includes/PackageDescriptorProcessor.php
@@ -0,0 +1,22 @@
 2+<?php
 3+
 4+/**
 5+ * File holding the PackageDescriptorProcessor class.
 6+ * Partly based on DeployDescriptorProcessor from Ontoprises Deployment Framework.
 7+ *
 8+ * @file PackageDescriptorProcessor.php
 9+ * @ingroup Deployment
 10+ *
 11+ * @author Jeroen De Dauw
 12+ * @author Kai Kühn
 13+ */
 14+
 15+/**
 16+ * Package description processing class.
 17+ *
 18+ * @author Jeroen De Dauw
 19+ * @author Kai Kühn
 20+ */
 21+class PackageDescriptorProcessor {
 22+
 23+}
\ No newline at end of file
Index: trunk/extensions/Deployment/includes/PackageRepository.php
@@ -10,10 +10,42 @@
1111 */
1212
1313 /**
14 - * Package description processing class.
 14+ * Base repository class. Deriving classes handle interaction with
 15+ * package repositories of the type they support.
1516 *
1617 * @author Jeroen De Dauw
1718 */
18 -class PackageRepository {
 19+abstract class PackageRepository {
1920
20 -}
\ No newline at end of file
 21+ /**
 22+ * Constructor.
 23+ */
 24+ public function __construct() {
 25+ // TODO
 26+ }
 27+
 28+}
 29+
 30+/**
 31+ * Class for interaction with the Ontoprise repository.
 32+ * @see PackageRepository
 33+ *
 34+ * @author Jeroen De Dauw
 35+ *
 36+ * TODO: move to it's own file
 37+ */
 38+class OntopriseRepository extends PackageRepository {
 39+
 40+ /**
 41+ * Constructor.
 42+ */
 43+ public function __construct() {
 44+ parent::__construct();
 45+
 46+ // TODO
 47+ }
 48+
 49+}
 50+
 51+// TODO: if the ontoprise repository structure is acceptable for general use, rename the class,
 52+// if it's not, design a more general repository structure and create a new PackageRepository class to handle.
\ No newline at end of file
Index: trunk/extensions/Deployment/includes/filesystems/FtpFilesystem.php
@@ -37,6 +37,8 @@
3838 * @param array $options
3939 */
4040 public function __construct( array $options ) {
 41+ parent::__construct();
 42+
4143 // Check if possible to use ftp functions.
4244 if ( !extension_loaded( 'ftp' ) ) {
4345 $this->addError( 'deploy-ftp-not-loaded' );
Index: trunk/extensions/Deployment/includes/filesystems/DirectFilesystem.php
@@ -21,7 +21,9 @@
2222 * Constructor.
2323 */
2424 public function __construct() {
 25+ parent::__construct();
2526
 27+ // TODO
2628 }
2729
2830 /**
Index: trunk/extensions/Deployment/includes/filesystems/Ssh2Filesystem.php
@@ -51,6 +51,8 @@
5252 * @param array $options
5353 */
5454 public function __construct( array $options ) {
 55+ parent::__construct();
 56+
5557 // Check if possible to use ssh2 functions.
5658 if ( !extension_loaded( 'ssh2' ) ) {
5759 $this->addError( 'deploy-ssh2-not-loaded' );
Index: trunk/extensions/Deployment/includes/PackageDescriptorParser.php
@@ -0,0 +1,74 @@
 2+<?php
 3+
 4+/**
 5+ * File holding the PackageDescriptorParser class.
 6+ * Partly based on DeployDescriptor from Ontoprises Deployment Framework.
 7+ *
 8+ * @file PackageDescriptor.php
 9+ * @ingroup Deployment
 10+ *
 11+ * @author Jeroen De Dauw
 12+ * @author Kai Kühn
 13+ */
 14+
 15+/**
 16+ * Base package description parsing class. Deriving classes
 17+ * can parse a package description in a certain format to a
 18+ * PackageDescriptor object.
 19+ *
 20+ * @author Jeroen De Dauw
 21+ * @author Kai Kühn
 22+ */
 23+abstract class PackageDescriptorParser {
 24+
 25+ /**
 26+ * Constructor.
 27+ */
 28+ public function __construct() {
 29+ // TODO
 30+ }
 31+
 32+}
 33+
 34+/**
 35+ * Parsing class for package desciprtions in XML.
 36+ * @see PackageDescriptorParser
 37+ *
 38+ * @author Jeroen De Dauw
 39+ * @author Kai Kühn
 40+ *
 41+ * TODO: move to it's own file
 42+ */
 43+class XMLDescriptorParser extends PackageDescriptorParser {
 44+
 45+ /**
 46+ * Constructor.
 47+ */
 48+ public function __construct() {
 49+ parent::__construct();
 50+
 51+ // TODO
 52+ }
 53+
 54+}
 55+
 56+/**
 57+ * Parsing class for package desciprtions in CPAN.
 58+ * @see PackageDescriptorParser
 59+ *
 60+ * @author Jeroen De Dauw
 61+ *
 62+ * TODO: move to it's own file
 63+ */
 64+class CPANDescriptorParser extends PackageDescriptorParser {
 65+
 66+ /**
 67+ * Constructor.
 68+ */
 69+ public function __construct() {
 70+ parent::__construct();
 71+
 72+ // TODO
 73+ }
 74+
 75+}
\ No newline at end of file

Status & tagging log