r70146 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70145‎ | r70146 | r70147 >
Date:17:54, 29 July 2010
Author:jeroendedauw
Status:ok (Comments)
Tags:
Comment:
Follow up to r70140
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -653,6 +653,8 @@
654654 /**
655655 * Show a short informational message.
656656 * Output looks like a list.
 657+ *
 658+ * @param srting $msg
657659 */
658660 public function showMessage( $msg /*, ... */ ) {
659661 $args = func_get_args();
@@ -662,6 +664,18 @@
663665 "</div>\n";
664666 $this->output->addHTML( $html );
665667 }
 668+
 669+ /**
 670+ * @param Status $status
 671+ */
 672+ public function showStatusMessage( Status $status ) {
 673+ $text = $status->getWikiText();
 674+ $this->output->addWikiText(
 675+ "<div class=\"config-message\">\n" .
 676+ $text .
 677+ "</div>"
 678+ );
 679+ }
666680
667681 /**
668682 * Label a control by wrapping a config-input div around it and putting a
Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -168,6 +168,14 @@
169169 );
170170
171171 /**
 172+ * TODO: doucment
 173+ *
 174+ * @param Status $status
 175+ */
 176+ public abstract function showStatusMessage( Status $status );
 177+
 178+
 179+ /**
172180 * Constructor, always call this from child classes.
173181 */
174182 public function __construct() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70140Removed showStatusMessage from the Installer and WebInstaller classes as it's...jeroendedauw15:20, 29 July 2010

Comments

#Comment by 😂 (talk | contribs)   09:47, 20 October 2010

Typo was fixed at some point :)

Status & tagging log