r69896 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69895‎ | r69896 | r69897 >
Date:19:36, 25 July 2010
Author:platonides
Status:reverted (Comments)
Tags:
Comment:
Remove unused globals.
Modified paths:
  • /trunk/phase3/maintenance/language/StatOutputs.php (modified) (history)
  • /trunk/phase3/maintenance/tests/ApiWatchTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/ApiWatchTest.php
@@ -95,7 +95,6 @@
9696 * @depends testWatchEdit
9797 */
9898 function testWatchClear( $data ) {
99 - global $wgUser;
10099 $data = $this->doApiRequest( array(
101100 'action' => 'query',
102101 'list' => 'watchlist' ), $data );
Index: trunk/phase3/maintenance/language/StatOutputs.php
@@ -31,7 +31,6 @@
3232 /** Outputs WikiText */
3333 class wikiStatsOutput extends statsOutput {
3434 function heading() {
35 - global $IP;
3635 $version = SpecialVersion::getVersion( 'nodb' );
3736 echo "'''Statistics are based on:''' <code>" . $version . "</code>\n\n";
3837 echo "'''Note:''' These statistics can be generated by running <code>php maintenance/language/transstat.php</code>.\n\n";

Follow-up revisions

RevisionCommit summaryAuthorDate
r69967Revert r69841, r69882, r69892, r69896, r69910 in phase3/maintenance/language ...siebrand20:29, 26 July 2010

Comments

#Comment by Hashar (talk | contribs)   12:13, 5 November 2010

back to new since it got reverted

#Comment by Platonides (talk | contribs)   23:30, 5 November 2010

Hashar, we have a 'reverted' status :)

Seems this was overly reverted in r69967, but since currently there aren't unused variables on those files, it probalby got reapplied later.

Status & tagging log