r69892 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69891‎ | r69892 | r69893 >
Date:18:39, 25 July 2010
Author:platonides
Status:reverted
Tags:
Comment:
Add a few globals.
Modified paths:
  • /trunk/phase3/maintenance/cleanupSpam.php (modified) (history)
  • /trunk/phase3/maintenance/language/dumpMessages.php (modified) (history)
  • /trunk/phase3/maintenance/renameDbPrefix.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/renameDbPrefix.php
@@ -35,6 +35,8 @@
3636 }
3737
3838 public function execute() {
 39+ global $wgDBname;
 40+
3941 // Allow for no old prefix
4042 if ( $this->getOption( 'old', 0 ) === '0' ) {
4143 $old = '';
@@ -82,4 +84,4 @@
8385 }
8486
8587 $maintClass = "RenameDbPrefix";
86 -require_once( DO_MAINTENANCE );
\ No newline at end of file
 88+require_once( DO_MAINTENANCE );
Index: trunk/phase3/maintenance/cleanupSpam.php
@@ -31,7 +31,7 @@
3232 }
3333
3434 public function execute() {
35 - global $wgLocalDatabases;
 35+ global $wgLocalDatabases, $wgUser;
3636
3737 $username = wfMsg( 'spambot_username' );
3838 $wgUser = User::newFromName( $username );
Index: trunk/phase3/maintenance/language/dumpMessages.php
@@ -31,11 +31,11 @@
3232 }
3333
3434 public function execute() {
 35+ global $wgVersion;
3536 $messages = array();
3637 foreach ( array_keys( Language::getMessagesFor( 'en' ) ) as $key ) {
3738 $messages[$key] = wfMsg( $key );
3839 }
39 - global $wgVersion;
4040 $this->output( "MediaWiki $wgVersion language file\n" );
4141 $this->output( serialize( $messages ) );
4242 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r69967Revert r69841, r69882, r69892, r69896, r69910 in phase3/maintenance/language ...siebrand20:29, 26 July 2010

Status & tagging log