| Index: trunk/extensions/CodeReview/svnImport.php |
| — | — | @@ -129,8 +129,8 @@ |
| 130 | 130 | $options |
| 131 | 131 | ); |
| 132 | 132 | while ( $row = $dbw->fetchObject( $res ) ) { |
| 133 | | - $rev = $repo->getRevision( $row->cr_id ); |
| 134 | | - $diff = $repo->getDiff( $row->cr_id ); // trigger caching |
| | 133 | + $repo->getRevision( $row->cr_id ); |
| | 134 | + $repo->getDiff( $row->cr_id ); // trigger caching |
| 135 | 135 | $this->output( "Diff r{$row->cr_id} done\n" ); |
| 136 | 136 | } |
| 137 | 137 | } |
| Index: trunk/extensions/CodeReview/api/ApiCodeDiff.php |
| — | — | @@ -22,7 +22,6 @@ |
| 23 | 23 | $this->dieUsage( "Invalid repo ``{$params['repo']}''", 'invalidrepo' ); |
| 24 | 24 | } |
| 25 | 25 | |
| 26 | | - $svn = SubversionAdaptor::newFromRepo( $repo->getPath() ); |
| 27 | 26 | $lastStoredRev = $repo->getLastStoredRev(); |
| 28 | 27 | |
| 29 | 28 | if ( $params['rev'] > $lastStoredRev ) { |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php |
| — | — | @@ -43,7 +43,7 @@ |
| 44 | 44 | if ( $this->validPost( 'codereview-post-comment' ) && strlen( $this->text ) ) { |
| 45 | 45 | $parent = $wgRequest->getIntOrNull( 'wpParent' ); |
| 46 | 46 | $review = $wgRequest->getInt( 'wpReview' ); |
| 47 | | - $isPreview = $wgRequest->getCheck( 'wpPreview' ); |
| | 47 | + //$isPreview = $wgRequest->getCheck( 'wpPreview' ); |
| 48 | 48 | $id = $this->mRev->saveComment( $this->text, $review, $parent ); |
| 49 | 49 | // For comments, take us back to the rev page focused on the new comment |
| 50 | 50 | if ( !$this->jumpToNext ) { |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php |
| — | — | @@ -173,8 +173,6 @@ |
| 174 | 174 | if ( $wgRequest->wasPosted() && $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) { |
| 175 | 175 | // Look for a posting... |
| 176 | 176 | $text = $wgRequest->getText( "wpReply{$this->mReplyTarget}" ); |
| 177 | | - $parent = $wgRequest->getIntOrNull( 'wpParent' ); |
| 178 | | - $review = $wgRequest->getInt( 'wpReview' ); |
| 179 | 177 | $isPreview = $wgRequest->getCheck( 'wpPreview' ); |
| 180 | 178 | if ( $isPreview ) { |
| 181 | 179 | // Save the text for reference on later comment display... |
| — | — | @@ -262,8 +260,6 @@ |
| 263 | 261 | protected function statusForm() { |
| 264 | 262 | global $wgUser; |
| 265 | 263 | if ( $wgUser->isAllowed( 'codereview-set-status' ) ) { |
| 266 | | - $repo = $this->mRepo->getName(); |
| 267 | | - $rev = $this->mRev->getId(); |
| 268 | 264 | return Xml::openElement( 'select', array( 'name' => 'wpStatus' ) ) . |
| 269 | 265 | self::buildStatusList( $this->mStatus, $this ) . |
| 270 | 266 | xml::closeElement( 'select' ); |
| — | — | @@ -569,8 +565,7 @@ |
| 570 | 566 | $preview = ''; |
| 571 | 567 | $text = $this->text; |
| 572 | 568 | } |
| 573 | | - $repo = $this->mRepo->getName(); |
| 574 | | - $rev = $this->mRev->getId(); |
| | 569 | + |
| 575 | 570 | if ( !$this->canPostComments() ) { |
| 576 | 571 | return ''; |
| 577 | 572 | } |
| Index: trunk/extensions/CodeReview/ui/CodeRepoListView.php |
| — | — | @@ -12,7 +12,6 @@ |
| 13 | 13 | } |
| 14 | 14 | $text = ''; |
| 15 | 15 | foreach ( $repos as $repo ) { |
| 16 | | - $name = $repo->getName(); |
| 17 | 16 | $text .= "* " . self::getNavItem( $repo ) . "\n"; |
| 18 | 17 | } |
| 19 | 18 | $wgOut->addWikiText( $text ); |