r69729 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69728‎ | r69729 | r69730 >
Date:14:09, 22 July 2010
Author:catrope
Status:deferred (Comments)
Tags:
Comment:
1.16wmf4: Merge Vector fixes from trunk: r65063, r68798, r69335, r69336, r69340, r69482, r69538, r68539, r69570
Modified paths:
  • /branches/wmf/1.16wmf4/skins (modified) (history)
  • /branches/wmf/1.16wmf4/skins/Vector.php (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/main-ltr.css (modified) (history)
  • /branches/wmf/1.16wmf4/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/skins/Vector.php
@@ -279,7 +279,7 @@
280280 // Checks if the user is logged in
281281 if ( $this->loggedin ) {
282282 if ( $wgVectorUseIconWatch ) {
283 - $class = 'icon ';
 283+ $class = 'icon';
284284 $place = 'views';
285285 } else {
286286 $class = '';
@@ -757,7 +757,7 @@
758758 <?php if ( $wgVectorUseSimpleSearch && $wgUser->getOption( 'vector-simplesearch' ) ): ?>
759759 <div id="simpleSearch">
760760 <input id="searchInput" name="search" type="text" <?php echo $this->skin->tooltipAndAccesskey( 'search' ); ?> <?php if( isset( $this->data['search'] ) ): ?> value="<?php $this->text( 'search' ) ?>"<?php endif; ?> />
761 - <button id="searchButton" type='submit' name='button' <?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?>>&nbsp;</button>
 761+ <button id="searchButton" type='submit' name='button' <?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?>><img src="<?php echo $GLOBALS['wgStylePath'] . "/{$this->skin->stylename}/images/search-" . ( $GLOBALS['wgContLang']->isRTL() ? 'rtl' : 'ltr' ) . '.png?' . $GLOBALS['wgStyleVersion'] ?>" alt="<?php $this->msg( 'searchbutton' ) ?>" /></button>
762762 </div>
763763 <?php else: ?>
764764 <input id="searchInput" name="search" type="text" <?php echo $this->skin->tooltipAndAccesskey( 'search' ); ?> <?php if( isset( $this->data['search'] ) ): ?> value="<?php $this->text( 'search' ) ?>"<?php endif; ?> />
Property changes on: branches/wmf/1.16wmf4/skins/Vector.php
___________________________________________________________________
Modified: svn:mergeinfo
765765 Merged /trunk/phase3/skins/Vector.php:r65036,65063,69335-69336,69340,69482,69538-69539,69570
Index: branches/wmf/1.16wmf4/skins/vector/main-ltr.css
@@ -351,6 +351,7 @@
352352 #simpleSearch {
353353 margin-top: 0.65em;
354354 position: relative;
 355+ min-height: 1px; /* Gotta trigger hasLayout for IE7 */
355356 border: solid 1px #AAAAAA;
356357 background-color: white;
357358 background-image: url(images/search-fade.png?1);
@@ -361,7 +362,13 @@
362363 font-size: 13px;
363364 top: 0.25em;
364365 }
365 - #simpleSearch input#searchInput {
 366+ div#simpleSearch .placeholder {
 367+ color: #999999;
 368+ }
 369+ div#simpleSearch input::-webkit-input-placeholder {
 370+ color: #999999;
 371+ }
 372+ div#simpleSearch input#searchInput {
366373 margin: 0;
367374 border-width: 0;
368375 padding: 3px;
@@ -373,27 +380,18 @@
374381 /* OVERRIDDEN BY COMPLIANT BROWSERS */
375382 #simpleSearch button#searchButton {
376383 padding: 0;
377 - margin: 5px 5px 0 5px;
378 - height: 13px;
379 - width: 12px;
 384+ margin: 0 5px;
380385 border: none;
381386 cursor: pointer;
382387 background-color: transparent;
383 - background-image: url(images/search-ltr.png?1);
384 - background-position: center center;
385 - background-repeat: no-repeat;
 388+ font-size: x-small;
386389 }
387 - .suggestions-special .special-label {
388 - font-size: 0.8em;
389 - color: gray;
 390+ div#simpleSearch button#searchButton img {
 391+ border: none;
 392+ margin: 0;
 393+ padding: 0;
 394+ vertical-align: middle;
390395 }
391 - .suggestions-special .special-query {
392 - color: black;
393 - font-style: italic;
394 - }
395 - .suggestions-special .special-hover {
396 - background-color: silver;
397 - }
398396 /* Panel */
399397 div#mw-panel {
400398 position: absolute;
@@ -728,7 +726,11 @@
729727 font-style: italic;
730728 }*/
731729 pre, code, tt {
732 - font-family: monospace, sans-serif;
 730+ /*
 731+ * It's important for this rule to first reference an actual font name, some browsers will render the monospace text
 732+ * too small otherwise, namely Firefox, Chrome and Safari
 733+ */
 734+ font-family: monospace, "Courier New";
733735 }
734736 code {
735737 background-color: #f9f9f9;
Index: branches/wmf/1.16wmf4/skins/vector/main-rtl.css
@@ -351,6 +351,7 @@
352352 #simpleSearch {
353353 margin-top: 0.65em;
354354 position: relative;
 355+ min-height: 1px; /* Gotta trigger hasLayout for IE7 */
355356 border: solid 1px #AAAAAA;
356357 background-color: white;
357358 background-image: url(images/search-fade.png?1);
@@ -361,7 +362,13 @@
362363 font-size: 13px;
363364 top: 0.25em;
364365 }
365 - #simpleSearch input#searchInput {
 366+ div#simpleSearch .placeholder {
 367+ color: #999999;
 368+ }
 369+ div#simpleSearch input::-webkit-input-placeholder {
 370+ color: #999999;
 371+ }
 372+ div#simpleSearch input#searchInput {
366373 margin: 0;
367374 border-width: 0;
368375 padding: 3px;
@@ -373,27 +380,18 @@
374381 /* OVERRIDDEN BY COMPLIANT BROWSERS */
375382 #simpleSearch button#searchButton {
376383 padding: 0;
377 - margin: 5px 5px 0 5px;
378 - height: 13px;
379 - width: 12px;
 384+ margin: 0 5px;
380385 border: none;
381386 cursor: pointer;
382387 background-color: transparent;
383 - background-image: url(images/search-rtl.png?1);
384 - background-position: center center;
385 - background-repeat: no-repeat;
 388+ font-size: x-small;
386389 }
387 - .suggestions-special .special-label {
388 - font-size: 0.8em;
389 - color: gray;
 390+ div#simpleSearch button#searchButton img {
 391+ border: none;
 392+ margin: 0;
 393+ padding: 0;
 394+ vertical-align: middle;
390395 }
391 - .suggestions-special .special-query {
392 - color: black;
393 - font-style: italic;
394 - }
395 - .suggestions-special .special-hover {
396 - background-color: silver;
397 - }
398396 /* Panel */
399397 div#mw-panel {
400398 position: absolute;
@@ -728,7 +726,11 @@
729727 font-style: italic;
730728 }*/
731729 pre, code, tt {
732 - font-family: monospace, sans-serif;
 730+ /*
 731+ * It's important for this rule to first reference an actual font name, some browsers will render the monospace text
 732+ * too small otherwise, namely Firefox, Chrome and Safari
 733+ */
 734+ font-family: monospace, "Courier New";
733735 }
734736 code {
735737 background-color: #f9f9f9;
Property changes on: branches/wmf/1.16wmf4/skins/vector
___________________________________________________________________
Modified: svn:mergeinfo
736738 Merged /trunk/phase3/skins/vector:r65036,65063,68798,69335-69336,69340,69482,69538-69539,69570
Property changes on: branches/wmf/1.16wmf4/skins
___________________________________________________________________
Modified: svn:mergeinfo
737739 Merged /trunk/phase3/skins:r65036,65063,69335-69336,69340,69482,69538-69539,69570

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65063Compliment to r65046 - Removing duplicate css from Vector's css fileadam13:26, 15 April 2010
r68539Followup r68536, typo in sqldemon01:39, 25 June 2010
r68798Vector - fix for bug 24190adam22:20, 30 June 2010
r69335Improves on the technique used in r65391 to fix the font-size issues in Firef...tparscal17:50, 14 July 2010
r69336By flipping '"Courier New", monospace' to 'monospace, "Courier New"', we can ...tparscal18:31, 14 July 2010
r69340Remove extra space.platonides19:19, 14 July 2010
r69482Accompanies r69481. Style changes for the new search placeholder textadam17:21, 17 July 2010
r69538* (bug 24401) SimpleSearch: No button/text indicating 'Search' if image is di...danny_b10:52, 19 July 2010
r69570Fix r69539: use $this->skin->stylename instead of $this->stylename, fix the p...catrope20:46, 19 July 2010

Comments

#Comment by 😂 (talk | contribs)   14:11, 22 July 2010

You didn't actually merge r68539 :)

#Comment by Catrope (talk | contribs)   14:32, 22 July 2010

That was r69539, sorry.

Status & tagging log