r69538 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69537‎ | r69538 | r69539 >
Date:10:52, 19 July 2010
Author:danny_b
Status:resolved
Tags:accessibility 
Comment:
* (bug 24401) SimpleSearch: No button/text indicating 'Search' if image is disabled
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -771,7 +771,7 @@
772772 <?php if ( $wgVectorUseSimpleSearch && $wgUser->getOption( 'vector-simplesearch' ) ): ?>
773773 <div id="simpleSearch">
774774 <input id="searchInput" name="search" type="text" <?php echo $this->skin->tooltipAndAccesskey( 'search' ); ?> <?php if( isset( $this->data['search'] ) ): ?> value="<?php $this->text( 'search' ) ?>"<?php endif; ?> />
775 - <button id="searchButton" type='submit' name='button' <?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?>>&#160;</button>
 775+ <button id="searchButton" type='submit' name='button' <?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?>><img src="<?php echo $wgStylePath . '/vector/search-' . ( $wgContLang->isRTL() ? 'rtl' : 'ltr' ) . '.png?' . $wgStyleVersion ?>" alt="<?php $this->msg( 'searchbutton' ) ?>" /></button>
776776 </div>
777777 <?php else: ?>
778778 <input id="searchInput" name="search" type="text" <?php echo $this->skin->tooltipAndAccesskey( 'search' ); ?> <?php if( isset( $this->data['search'] ) ): ?> value="<?php $this->text( 'search' ) ?>"<?php endif; ?> />
Index: trunk/phase3/skins/vector/main-ltr.css
@@ -383,16 +383,18 @@
384384 /* OVERRIDDEN BY COMPLIANT BROWSERS */
385385 div#simpleSearch button#searchButton {
386386 padding: 0;
387 - margin: 5px 5px 0 5px;
388 - height: 13px;
389 - width: 12px;
 387+ margin: 0 5px;
390388 border: none;
391389 cursor: pointer;
392390 background-color: transparent;
393 - background-image: url(images/search-ltr.png?1);
394 - background-position: center center;
395 - background-repeat: no-repeat;
 391+ font-size: x-small;
396392 }
 393+ div#simpleSearch button#searchButton img {
 394+ border: none;
 395+ margin: 0;
 396+ padding: 0;
 397+ vertical-align: middle;
 398+ }
397399 /* Panel */
398400 div#mw-panel {
399401 position: absolute;
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -383,16 +383,18 @@
384384 /* OVERRIDDEN BY COMPLIANT BROWSERS */
385385 div#simpleSearch button#searchButton {
386386 padding: 0;
387 - margin: 5px 5px 0 5px;
388 - height: 13px;
389 - width: 12px;
 387+ margin: 0 5px;
390388 border: none;
391389 cursor: pointer;
392390 background-color: transparent;
393 - background-image: url(images/search-rtl.png?1);
394 - background-position: center center;
395 - background-repeat: no-repeat;
 391+ font-size: x-small;
396392 }
 393+ div#simpleSearch button#searchButton img {
 394+ border: none;
 395+ margin: 0;
 396+ padding: 0;
 397+ vertical-align: middle;
 398+ }
397399 /* Panel */
398400 div#mw-panel {
399401 position: absolute;
Index: trunk/phase3/RELEASE-NOTES
@@ -242,6 +242,7 @@
243243 * (bug 24244) Updated comments in DefaultSettings.php to reflect Image: --> File:
244244 namespace rename.
245245 * Make wfTimestamp recognize negative unix timestamp values.
 246+* (bug 24401) SimpleSearch: No button/text indicating 'Search' if image is disabled
246247
247248 === API changes in 1.17 ===
248249 * (bug 22738) Allow filtering by action type on query=logevent.

Follow-up revisions

RevisionCommit summaryAuthorDate
r69539Follow up to r69538: Use $stylename member instead of hardcoding vector.danny_b10:58, 19 July 2010
r697291.16wmf4: Merge Vector fixes from trunk: r65063, r68798, r69335, r69336, r693...catrope14:09, 22 July 2010

Status & tagging log