r69482 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69481‎ | r69482 | r69483 >
Date:17:21, 17 July 2010
Author:adam
Status:ok (Comments)
Tags:
Comment:
Accompanies r69481. Style changes for the new search placeholder text
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -361,6 +361,12 @@
362362 font-size: 13px;
363363 top: 0.25em;
364364 }
 365+ div#simpleSearch .placeholder {
 366+ color: #999999;
 367+ }
 368+ div#simpleSearch input::-webkit-input-placeholder {
 369+ color: #999999;
 370+ }
365371 div#simpleSearch input#searchInput {
366372 margin: 0;
367373 border-width: 0;
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -361,6 +361,12 @@
362362 font-size: 13px;
363363 top: 0.25em;
364364 }
 365+ div#simpleSearch .placeholder {
 366+ color: #999999;
 367+ }
 368+ div#simpleSearch input::-webkit-input-placeholder {
 369+ color: #999999;
 370+ }
365371 div#simpleSearch input#searchInput {
366372 margin: 0;
367373 border-width: 0;
Index: trunk/phase3/includes/DefaultSettings.php
——@@ -1547,7 +1547,7 @@
15481548 * to ensure that client-side caches do not keep obsolete copies of global
15491549 * styles.
15501550 */
1551 -$wgStyleVersion = '297';
 1551+$wgStyleVersion = '298';
15521552
15531553 /**
15541554 * This will cache static pages for non-logged-in users to reduce

Follow-up revisions

RevisionCommit summaryAuthorDate
r697291.16wmf4: Merge Vector fixes from trunk: r65063, r68798, r69335, r69336, r693...catrope14:09, 22 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69481SimpleSearch - moving away from our label-based placeholder text, to input-on...adam17:17, 17 July 2010

Comments

#Comment by Catrope (talk | contribs)   19:26, 19 July 2010 
+	div#simpleSearch input::-webkit-input-placeholder {

What about other browsers that do support the placeholder attribute?

#Comment by Adammiller~mediawikiwiki (talk | contribs)   19:29, 19 July 2010

What other browser? Pretty sure that webkit is the only one that has implemented styling support for it.

#Comment by Catrope (talk | contribs)   19:30, 19 July 2010

Hmm. Is there no standard way to style placeholders then? That's kinda ridiculous.

#Comment by Catrope (talk | contribs)   19:30, 19 July 2010

Hmm. Is there no standard way to style placeholders then? That's kinda ridiculous.

#Comment by Simetrical (talk | contribs)   19:38, 19 July 2010

See these threads:

http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2010-February/025190.html http://lists.w3.org/Archives/Public/www-style/2010Mar/0095.html

Currently it's not standardized.  ::-moz-placeholder is intended to work in future versions of Gecko (see <https://bugzilla.mozilla.org/show_bug.cgi?id=457801>), but apparently isn't implemented yet. Maybe best to include it for future-proofing.

#Comment by Simetrical (talk | contribs)   19:39, 19 July 2010

Why is URL parsing in Code Review so broken . . . ?

#Comment by Adammiller~mediawikiwiki (talk | contribs)   20:29, 19 July 2010

I don't think we need to be fixing problems we don't have yet. They don't seem to be resolved yet on using ::value or ::-moz-placeholder so I'd say we just hold off until it becomes a problem.

#Comment by Catrope (talk | contribs)   20:47, 19 July 2010

As there's no standard yet, this is fine.

Status & tagging log