r69359 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69358‎ | r69359 | r69360 >
Date:22:44, 14 July 2010
Author:mah
Status:reverted (Comments)
Tags:
Comment:
re r67320: output a newline if we switch from channeled to unchanneled output
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
——@@ -226,6 +226,7 @@
227227 }
228228 if ( $channel === null ) {
229229 $f = fopen( 'php://stdout', 'w' );
 230+ if ( $this->lastChannel !== null ) fwrite( $f, "\n" );
230231 fwrite( $f, $out );
231232 fclose( $f );
232233 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67320restore default behavior for Maintenance::output when no channel specified (c...ariel01:43, 4 June 2010

Comments

#Comment by Tim Starling (talk | contribs)   02:58, 20 July 2010

Is there any script that is affected by this?

#Comment by MarkAHershberger (talk | contribs)   23:54, 20 July 2010

This was replaced in r69389 after getting input from Ariel and Nikerabbit in r67320

Status & tagging log