r69358 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69357‎ | r69358 | r69359 >
Date:22:40, 14 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed issues with php strict standards
Modified paths:
  • /trunk/extensions/SemanticTasks/SemanticTasks.classes.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticTasks/SemanticTasks.classes.php
@@ -65,7 +65,7 @@
6666 return true;
6767 }
6868
69 - function mailAssignees( $article, $text, $user, $status ) {
 69+ static function mailAssignees( $article, $text, $user, $status ) {
7070 self::printDebug( "Saved assignees:", self::$task_assignees );
7171 self::printDebug( "Saved task status: " . self::$task_status );
7272
@@ -125,7 +125,7 @@
126126 * Returns an array of properties based on $query_word
127127 * @param $query_word String: the property that designate the users to notify.
128128 */
129 - function getAssignees( $query_word, $title_text, $user ) {
 129+ static function getAssignees( $query_word, $title_text, $user ) {
130130 // Array of assignees to return
131131 $assignee_arr = array();
132132
@@ -158,7 +158,7 @@
159159 * Returns an array of properties based on $query_word
160160 * @param $query_word String: the property that designate the users to notify.
161161 */
162 - function getStatus( $query_word, $title_text, $user ) {
 162+ static function getStatus( $query_word, $title_text, $user ) {
163163 // Array of assignees to return
164164 $assignee_arr = array();
165165
@@ -237,7 +237,7 @@
238238 return $assignee_arr;
239239 }
240240
241 - function getAssigneeAddresses( $assignees ) {
 241+ static function getAssigneeAddresses( $assignees ) {
242242 $assignee_arr = array();
243243 foreach ( $assignees as $assignee_name ) {
244244 $assignee = User::newFromName( $assignee_name );
@@ -326,7 +326,7 @@
327327 * @param $display_title Boolean : add the page title in the result
328328 * @return TODO
329329 */
330 - function getQueryResults( $query_string, $properties_to_display, $display_title ) {
 330+ static function getQueryResults( $query_string, $properties_to_display, $display_title ) {
331331 // i18n
332332 wfLoadExtensionMessages( 'SemanticTasks' );
333333
@@ -424,7 +424,7 @@
425425 * @param string $debugVal
426426 * @access private
427427 */
428 - function printDebug( $debugText, $debugArr = null ) {
 428+ static function printDebug( $debugText, $debugArr = null ) {
429429 global $wgSemanticTasksDebug;
430430
431431 if ( $wgSemanticTasksDebug ) {
@@ -436,4 +436,4 @@
437437 }
438438 }
439439 }
440 -}
 440+}
\ No newline at end of file

Status & tagging log