r69126 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69125‎ | r69126 | r69127 >
Date:01:12, 7 July 2010
Author:tstarling
Status:deferred (Comments)
Tags:
Comment:
MFT r68236 (bug 23465): Don't ignore the predefined destination filename on Special:Upload after following a red link
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/specials/SpecialUpload.php
@@ -1003,7 +1003,10 @@
10041004 $scriptVars = array(
10051005 'wgAjaxUploadDestCheck' => $useAjaxDestCheck,
10061006 'wgAjaxLicensePreview' => $useAjaxLicensePreview,
1007 - 'wgUploadAutoFill' => !$this->mForReUpload,
 1007+ 'wgUploadAutoFill' => !$this->mForReUpload &&
 1008+ // If we received mDestFile from the request, don't autofill
 1009+ // the wpDestFile textbox
 1010+ $this->mDestFile === '',
10081011 'wgUploadSourceIds' => $this->mSourceIds,
10091012 );
10101013
Property changes on: branches/REL1_16/phase3/includes/specials/SpecialUpload.php
___________________________________________________________________
Added: svn:mergeinfo
10111014 Merged /branches/wmf-deployment/includes/specials/SpecialUpload.php:r53381,56967
10121015 Merged /branches/REL1_15/phase3/includes/specials/SpecialUpload.php:r51646
10131016 Merged /branches/sqlite/includes/specials/SpecialUpload.php:r58211-58321
10141017 Merged /trunk/phase3/includes/specials/SpecialUpload.php:r63045,63047,63490,63549,63764,63897-63901,64180,64837,64846,64860,64862,64881,64948,64957,65025,65029,66944,68236
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -57,6 +57,8 @@
5858 * (bug 23597) Fixed conflicts between ID attributes in the Vector skin and
5959 parser-generated heading IDs. Renamed head, panel, head-base and page-base.
6060 * Disabled $wgHitcounterUpdateFreq>1 feature on SQLite, does not work yet.
 61+* (bug 23465) Don't ignore the predefined destination filename on
 62+ Special:Upload after following a red link to a file.
6163
6264 == Changes since 1.16 beta 2 ==
6365

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68236(bug 23465) Don't ignore the predefined destination filename on Special:Upl...btongminh20:09, 18 June 2010

Comments

#Comment by Bryan (talk | contribs)   13:42, 7 July 2010

I would also like to have it rolled out to wmf-deployment if possible.

Status & tagging log